Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Unified Diff: content/browser/web_contents/web_contents_impl.h

Issue 1162373002: Make some editing/selection functions accessible to c/b/renderer_host/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed sadrul@'s comments Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/web_contents/web_contents_impl.h
diff --git a/content/browser/web_contents/web_contents_impl.h b/content/browser/web_contents/web_contents_impl.h
index a6c62111f7dafdbb09c769cdf8e49a962a4a7510..d9294772adcf82803b1158c03bee7fb8f4be48c1 100644
--- a/content/browser/web_contents/web_contents_impl.h
+++ b/content/browser/web_contents/web_contents_impl.h
@@ -505,7 +505,6 @@ class CONTENT_EXPORT WebContentsImpl
void SetIsVirtualKeyboardRequested(bool requested) override;
bool IsVirtualKeyboardRequested() override;
-
// NavigatorDelegate ---------------------------------------------------------
void DidStartProvisionalLoad(RenderFrameHostImpl* render_frame_host,
@@ -565,6 +564,12 @@ class CONTENT_EXPORT WebContentsImpl
BrowserAccessibilityManager* GetRootBrowserAccessibilityManager() override;
BrowserAccessibilityManager* GetOrCreateRootBrowserAccessibilityManager()
override;
+ // Following three functions are already listed under WebContents overrides.
nasko 2015/06/04 20:18:00 Why is this comment beneficial?
mohsen 2015/06/04 23:11:38 If we don't include this comment and three below l
+ // void Cut() override;
+ // void Copy() override;
+ // void Paste() override;
+ void MoveRangeSelectionExtent(const gfx::Point& extent) override;
+ void SelectRange(const gfx::Point& base, const gfx::Point& extent) override;
// RenderFrameHostManager::Delegate ------------------------------------------
@@ -674,13 +679,6 @@ class CONTENT_EXPORT WebContentsImpl
typedef base::Callback<void(WebContents*)> CreatedCallback;
- // Requests the renderer to move the selection extent to a new position.
- void MoveRangeSelectionExtent(const gfx::Point& extent);
-
- // Requests the renderer to select the region between two points in the
- // currently focused frame.
- void SelectRange(const gfx::Point& base, const gfx::Point& extent);
-
// Forces overscroll to be disabled (used by touch emulation).
void SetForceDisableOverscrollContent(bool force_disable);

Powered by Google App Engine
This is Rietveld 408576698