Make some editing/selection functions accessible to c/b/renderer_host/

content/browser/web_contents/web_contents_impl.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_
 #define CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_
 
 #include <map>
 #include <set>
 #include <string>
@@ skipping 487 matching lines @@
       const MediaResponseCallback& callback) override;
   bool CheckMediaAccessPermission(const GURL& security_origin,
                                   MediaStreamType type) override;
   SessionStorageNamespace* GetSessionStorageNamespace(
       SiteInstance* instance) override;
   SessionStorageNamespaceMap GetSessionStorageNamespaceMap() override;
   FrameTree* GetFrameTree() override;
   void SetIsVirtualKeyboardRequested(bool requested) override;
   bool IsVirtualKeyboardRequested() override;
 
-
   // NavigatorDelegate ---------------------------------------------------------
 
   void DidStartProvisionalLoad(RenderFrameHostImpl* render_frame_host,
                                const GURL& validated_url,
                                bool is_error_page,
                                bool is_iframe_srcdoc) override;
   void DidFailProvisionalLoadWithError(
       RenderFrameHostImpl* render_frame_host,
       const FrameHostMsg_DidFailProvisionalLoadWithError_Params& params)
       override;
@@ skipping 39 matching lines @@
   void ScreenInfoChanged() override;
   bool PreHandleKeyboardEvent(const NativeWebKeyboardEvent& event,
                               bool* is_keyboard_shortcut) override;
   void HandleKeyboardEvent(const NativeWebKeyboardEvent& event) override;
   bool HandleWheelEvent(const blink::WebMouseWheelEvent& event) override;
   bool PreHandleGestureEvent(const blink::WebGestureEvent& event) override;
   void DidSendScreenRects(RenderWidgetHostImpl* rwh) override;
   BrowserAccessibilityManager* GetRootBrowserAccessibilityManager() override;
   BrowserAccessibilityManager* GetOrCreateRootBrowserAccessibilityManager()
       override;
+  // Following three functions are already listed under WebContents overrides.

[nasko, 2015/06/04 20:18:00]

Why is this comment beneficial?

[mohsen, 2015/06/04 23:11:38]

If we don't include this comment and three below lines, someone reading the code
might get confused at why these functions from RenderWidgetHostDelegate are not
implemented.

And, if we only include the following three commented lines, again it would be
confusing as why these commented function declarations are in the code.

So, I followed the similar pattern used in line 434.

+  // void Cut() override;
+  // void Copy() override;
+  // void Paste() override;
+  void MoveRangeSelectionExtent(const gfx::Point& extent) override;
+  void SelectRange(const gfx::Point& base, const gfx::Point& extent) override;
 
   // RenderFrameHostManager::Delegate ------------------------------------------
 
   bool CreateRenderViewForRenderManager(
       RenderViewHost* render_view_host,
       int opener_route_id,
       int proxy_routing_id,
       bool for_main_frame_navigation) override;
   bool CreateRenderFrameForRenderManager(RenderFrameHost* render_frame_host,
                                          int parent_routing_id,
@@ skipping 89 matching lines @@
 
   // Changes the IsLoading state and notifies the delegate as needed.
   // |details| is used to provide details on the load that just finished
   // (but can be null if not applicable).
   void SetIsLoading(bool is_loading,
                     bool to_different_document,
                     LoadNotificationDetails* details) override;
 
   typedef base::Callback<void(WebContents*)> CreatedCallback;
 
-  // Requests the renderer to move the selection extent to a new position.
-  void MoveRangeSelectionExtent(const gfx::Point& extent);
-
-  // Requests the renderer to select the region between two points in the
-  // currently focused frame.
-  void SelectRange(const gfx::Point& base, const gfx::Point& extent);
-
   // Forces overscroll to be disabled (used by touch emulation).
   void SetForceDisableOverscrollContent(bool force_disable);
 
   AudioStateProvider* audio_state_provider() {
     return audio_state_provider_.get();
   }
 
   bool has_audio_power_save_blocker_for_testing() const {
     return audio_power_save_blocker_;
   }
@@ skipping 590 matching lines @@
   // Adds/removes a callback called on creation of each new WebContents.
   static void AddCreatedCallbackForTesting(const CreatedCallback& callback);
   static void RemoveCreatedCallbackForTesting(const CreatedCallback& callback);
 
   DISALLOW_COPY_AND_ASSIGN(FriendZone);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_