Source/web/ChromeClientImpl.h - Issue 1162263007: Cleanup: Move code common in ChromeClient JavaScript dialog functions to a function template.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/ChromeClientImpl.h

Issue 1162263007: Cleanup: Move code common in ChromeClient JavaScript dialog functions to a function template. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/ChromeClientImpl.h

diff --git a/Source/web/ChromeClientImpl.h b/Source/web/ChromeClientImpl.h

index 6467d88dcd1e4551936f84ead09672cd3dcc491a..b6083ab3324364c016802625a734cf9ce1436b05 100644

--- a/Source/web/ChromeClientImpl.h

+++ b/Source/web/ChromeClientImpl.h

@@ -96,8 +96,7 @@ public:

const WTF::String& message, unsigned lineNumber,

const WTF::String& sourceID, const WTF::String& stackTrace) override;

virtual bool canRunBeforeUnloadConfirmPanel() override;

- virtual bool runBeforeUnloadConfirmPanelInternal(

- const WTF::String& message, LocalFrame*) override;

+ virtual bool runBeforeUnloadConfirmPanelInternal(LocalFrame*, const String&) override;

virtual void closeWindowSoon() override;

virtual void runJavaScriptAlertInternal(LocalFrame*, const String&) override;

virtual bool runJavaScriptConfirmInternal(LocalFrame*, const String&) override;

« no previous file with comments | « Source/core/page/ChromeClient.cpp ('k') | Source/web/ChromeClientImpl.cpp » ('j') | no next file with comments »