Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Side by Side Diff: Source/web/ChromeClientImpl.h

Issue 1162263007: Cleanup: Move code common in ChromeClient JavaScript dialog functions to a function template. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/page/ChromeClient.cpp ('k') | Source/web/ChromeClientImpl.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies). 3 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies).
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are 6 * modification, are permitted provided that the following conditions are
7 * met: 7 * met:
8 * 8 *
9 * * Redistributions of source code must retain the above copyright 9 * * Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 78 matching lines...) Expand 10 before | Expand all | Expand 10 after
89 virtual bool scrollbarsVisible() override; 89 virtual bool scrollbarsVisible() override;
90 virtual void setMenubarVisible(bool) override; 90 virtual void setMenubarVisible(bool) override;
91 virtual bool menubarVisible() override; 91 virtual bool menubarVisible() override;
92 virtual void setResizable(bool) override; 92 virtual void setResizable(bool) override;
93 virtual bool shouldReportDetailedMessageForSource(LocalFrame&, const WTF::St ring&) override; 93 virtual bool shouldReportDetailedMessageForSource(LocalFrame&, const WTF::St ring&) override;
94 virtual void addMessageToConsole( 94 virtual void addMessageToConsole(
95 LocalFrame*, MessageSource, MessageLevel, 95 LocalFrame*, MessageSource, MessageLevel,
96 const WTF::String& message, unsigned lineNumber, 96 const WTF::String& message, unsigned lineNumber,
97 const WTF::String& sourceID, const WTF::String& stackTrace) override; 97 const WTF::String& sourceID, const WTF::String& stackTrace) override;
98 virtual bool canRunBeforeUnloadConfirmPanel() override; 98 virtual bool canRunBeforeUnloadConfirmPanel() override;
99 virtual bool runBeforeUnloadConfirmPanelInternal( 99 virtual bool runBeforeUnloadConfirmPanelInternal(LocalFrame*, const String&) override;
100 const WTF::String& message, LocalFrame*) override;
101 virtual void closeWindowSoon() override; 100 virtual void closeWindowSoon() override;
102 virtual void runJavaScriptAlertInternal(LocalFrame*, const String&) override ; 101 virtual void runJavaScriptAlertInternal(LocalFrame*, const String&) override ;
103 virtual bool runJavaScriptConfirmInternal(LocalFrame*, const String&) overri de; 102 virtual bool runJavaScriptConfirmInternal(LocalFrame*, const String&) overri de;
104 virtual bool runJavaScriptPromptInternal( 103 virtual bool runJavaScriptPromptInternal(
105 LocalFrame*, const WTF::String& message, 104 LocalFrame*, const WTF::String& message,
106 const WTF::String& defaultValue, WTF::String& result) override; 105 const WTF::String& defaultValue, WTF::String& result) override;
107 virtual void setStatusbarText(const WTF::String& message) override; 106 virtual void setStatusbarText(const WTF::String& message) override;
108 virtual bool tabsToLinks() override; 107 virtual bool tabsToLinks() override;
109 virtual IntRect windowResizerRect() const override; 108 virtual IntRect windowResizerRect() const override;
110 virtual void invalidateRect(const IntRect&) override; 109 virtual void invalidateRect(const IntRect&) override;
(...skipping 79 matching lines...) Expand 10 before | Expand all | Expand 10 after
190 WindowFeatures m_windowFeatures; 189 WindowFeatures m_windowFeatures;
191 190
192 PagePopupDriver* m_pagePopupDriver; 191 PagePopupDriver* m_pagePopupDriver;
193 }; 192 };
194 193
195 DEFINE_TYPE_CASTS(ChromeClientImpl, ChromeClient, client, client->isChromeClient Impl(), client.isChromeClientImpl()); 194 DEFINE_TYPE_CASTS(ChromeClientImpl, ChromeClient, client, client->isChromeClient Impl(), client.isChromeClientImpl());
196 195
197 } // namespace blink 196 } // namespace blink
198 197
199 #endif 198 #endif
OLDNEW
« no previous file with comments | « Source/core/page/ChromeClient.cpp ('k') | Source/web/ChromeClientImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698