Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Unified Diff: Source/core/page/ChromeClient.h

Issue 1162263007: Cleanup: Move code common in ChromeClient JavaScript dialog functions to a function template. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/loader/EmptyClients.h ('k') | Source/core/page/ChromeClient.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/page/ChromeClient.h
diff --git a/Source/core/page/ChromeClient.h b/Source/core/page/ChromeClient.h
index e7c460782b65609c6ddf30f8380e9cc1092c8c34..14e72b9e4255e12873797fd2454b4d2b1db47125 100644
--- a/Source/core/page/ChromeClient.h
+++ b/Source/core/page/ChromeClient.h
@@ -239,6 +239,7 @@ public:
void registerPopupOpeningObserver(PopupOpeningObserver*);
void unregisterPopupOpeningObserver(PopupOpeningObserver*);
+ void notifyPopupOpeningObservers() const;
protected:
virtual ~ChromeClient() { }
@@ -248,7 +249,7 @@ protected:
// should give better names, or move out non-internal versions of these
// functions.
virtual void setWindowRectInternal(const IntRect&) = 0;
- virtual bool runBeforeUnloadConfirmPanelInternal(const String& message, LocalFrame*) = 0;
+ virtual bool runBeforeUnloadConfirmPanelInternal(LocalFrame*, const String& message) = 0;
virtual void runJavaScriptAlertInternal(LocalFrame*, const String&) = 0;
virtual bool runJavaScriptConfirmInternal(LocalFrame*, const String&) = 0;
virtual bool runJavaScriptPromptInternal(LocalFrame*, const String& message, const String& defaultValue, String& result) = 0;
@@ -263,7 +264,6 @@ protected:
private:
bool canRunModalIfDuringPageDismissal(Frame* mainFrame, DialogType, const String& message);
void setToolTip(const HitTestResult&);
- void notifyPopupOpeningObservers() const;
Vector<PopupOpeningObserver*> m_popupOpeningObservers;
Cursor m_lastSetMouseCursorForTesting;
« no previous file with comments | « Source/core/loader/EmptyClients.h ('k') | Source/core/page/ChromeClient.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698