Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Side by Side Diff: Source/core/page/ChromeClient.h

Issue 1162263007: Cleanup: Move code common in ChromeClient JavaScript dialog functions to a function template. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/loader/EmptyClients.h ('k') | Source/core/page/ChromeClient.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple, Inc. All rights reserved. 2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple, Inc. All rights reserved.
3 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies). 3 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies).
4 * Copyright (C) 2012 Samsung Electronics. All rights reserved. 4 * Copyright (C) 2012 Samsung Electronics. All rights reserved.
5 * 5 *
6 * This library is free software; you can redistribute it and/or 6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public 7 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either 8 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version. 9 * version 2 of the License, or (at your option) any later version.
10 * 10 *
(...skipping 221 matching lines...) Expand 10 before | Expand all | Expand 10 after
232 virtual void showImeIfNeeded() { } 232 virtual void showImeIfNeeded() { }
233 233
234 virtual void registerViewportLayers() const { } 234 virtual void registerViewportLayers() const { }
235 235
236 virtual void showUnhandledTapUIIfNeeded(IntPoint, Node*, bool) { } 236 virtual void showUnhandledTapUIIfNeeded(IntPoint, Node*, bool) { }
237 237
238 virtual void didUpdateTopControls() const { } 238 virtual void didUpdateTopControls() const { }
239 239
240 void registerPopupOpeningObserver(PopupOpeningObserver*); 240 void registerPopupOpeningObserver(PopupOpeningObserver*);
241 void unregisterPopupOpeningObserver(PopupOpeningObserver*); 241 void unregisterPopupOpeningObserver(PopupOpeningObserver*);
242 void notifyPopupOpeningObservers() const;
242 243
243 protected: 244 protected:
244 virtual ~ChromeClient() { } 245 virtual ~ChromeClient() { }
245 246
246 virtual void showMouseOverURL(const HitTestResult&) = 0; 247 virtual void showMouseOverURL(const HitTestResult&) = 0;
247 // TODO(tkent): Adding 'Internal' to virtual functions is not good. We 248 // TODO(tkent): Adding 'Internal' to virtual functions is not good. We
248 // should give better names, or move out non-internal versions of these 249 // should give better names, or move out non-internal versions of these
249 // functions. 250 // functions.
250 virtual void setWindowRectInternal(const IntRect&) = 0; 251 virtual void setWindowRectInternal(const IntRect&) = 0;
251 virtual bool runBeforeUnloadConfirmPanelInternal(const String& message, Loca lFrame*) = 0; 252 virtual bool runBeforeUnloadConfirmPanelInternal(LocalFrame*, const String& message) = 0;
252 virtual void runJavaScriptAlertInternal(LocalFrame*, const String&) = 0; 253 virtual void runJavaScriptAlertInternal(LocalFrame*, const String&) = 0;
253 virtual bool runJavaScriptConfirmInternal(LocalFrame*, const String&) = 0; 254 virtual bool runJavaScriptConfirmInternal(LocalFrame*, const String&) = 0;
254 virtual bool runJavaScriptPromptInternal(LocalFrame*, const String& message, const String& defaultValue, String& result) = 0; 255 virtual bool runJavaScriptPromptInternal(LocalFrame*, const String& message, const String& defaultValue, String& result) = 0;
255 virtual void printInternal(LocalFrame*) = 0; 256 virtual void printInternal(LocalFrame*) = 0;
256 virtual PassOwnPtrWillBeRawPtr<ColorChooser> createColorChooserInternal(Loca lFrame*, ColorChooserClient*, const Color&) = 0; 257 virtual PassOwnPtrWillBeRawPtr<ColorChooser> createColorChooserInternal(Loca lFrame*, ColorChooserClient*, const Color&) = 0;
257 virtual PassRefPtr<DateTimeChooser> openDateTimeChooserInternal(DateTimeChoo serClient*, const DateTimeChooserParameters&) = 0; 258 virtual PassRefPtr<DateTimeChooser> openDateTimeChooserInternal(DateTimeChoo serClient*, const DateTimeChooserParameters&) = 0;
258 virtual void openTextDataListChooserInternal(HTMLInputElement&) = 0; 259 virtual void openTextDataListChooserInternal(HTMLInputElement&) = 0;
259 virtual void runOpenPanelInternal(LocalFrame*, PassRefPtr<FileChooser>) = 0; 260 virtual void runOpenPanelInternal(LocalFrame*, PassRefPtr<FileChooser>) = 0;
260 virtual PassRefPtrWillBeRawPtr<PopupMenu> createPopupMenuInternal(LocalFrame &, PopupMenuClient*) = 0; 261 virtual PassRefPtrWillBeRawPtr<PopupMenu> createPopupMenuInternal(LocalFrame &, PopupMenuClient*) = 0;
261 virtual void setCursorInternal(const Cursor&) = 0; 262 virtual void setCursorInternal(const Cursor&) = 0;
262 263
263 private: 264 private:
264 bool canRunModalIfDuringPageDismissal(Frame* mainFrame, DialogType, const St ring& message); 265 bool canRunModalIfDuringPageDismissal(Frame* mainFrame, DialogType, const St ring& message);
265 void setToolTip(const HitTestResult&); 266 void setToolTip(const HitTestResult&);
266 void notifyPopupOpeningObservers() const;
267 267
268 Vector<PopupOpeningObserver*> m_popupOpeningObservers; 268 Vector<PopupOpeningObserver*> m_popupOpeningObservers;
269 Cursor m_lastSetMouseCursorForTesting; 269 Cursor m_lastSetMouseCursorForTesting;
270 }; 270 };
271 271
272 } // namespace blink 272 } // namespace blink
273 273
274 #endif // ChromeClient_h 274 #endif // ChromeClient_h
OLDNEW
« no previous file with comments | « Source/core/loader/EmptyClients.h ('k') | Source/core/page/ChromeClient.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698