content/renderer/service_worker/embedded_worker_context_client.cc - Issue 1162243003: BackgroundSync sync events need to be ExtendableEvents, content side

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/service_worker/embedded_worker_context_client.cc

Issue 1162243003: BackgroundSync sync events need to be ExtendableEvents, content side (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Avoid race condition in sync event dispatch Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/service_worker/embedded_worker_context_client.h ('k') | content/renderer/service_worker/service_worker_script_context.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/service_worker/embedded_worker_context_client.cc

diff --git a/content/renderer/service_worker/embedded_worker_context_client.cc b/content/renderer/service_worker/embedded_worker_context_client.cc

index 4cf19419c83c599f7231c6e2d3c4c503c1e8c1b4..abbb66aa936714d8051d3b4d3baae60cf16ef118 100644

--- a/content/renderer/service_worker/embedded_worker_context_client.cc

+++ b/content/renderer/service_worker/embedded_worker_context_client.cc

@@ -334,9 +334,16 @@ void EmbeddedWorkerContextClient::didHandlePushEvent(

script_context_->DidHandlePushEvent(request_id, result);

}

+// TODO(chasej): crbug.com/486890 - Remove when matching blink changes land

void EmbeddedWorkerContextClient::didHandleSyncEvent(int request_id) {

+ didHandleSyncEvent(request_id, blink::WebServiceWorkerEventResultCompleted);

+void EmbeddedWorkerContextClient::didHandleSyncEvent(

+ int request_id,

+ blink::WebServiceWorkerEventResult result) {

DCHECK(script_context_);

- script_context_->DidHandleSyncEvent(request_id);

+ script_context_->DidHandleSyncEvent(request_id, result);

}

void EmbeddedWorkerContextClient::didHandleCrossOriginConnectEvent(