Issue 11622009: Forward Webkit Gesture events to interested RenderViewObservers.

Issue 11622009: Forward Webkit Gesture events to interested RenderViewObservers. (Closed)

Created:
8 years ago by ananta

Modified:
8 years ago

Reviewers:
jam

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Forward Webkit Gesture events to interested RenderViewObservers. The ChromeRenderViewObserver overrides the RenderViewObserver::DidHandleGestureEvent virtual and forwards the ChromeViewHostMsg_FocusedEditableNodeTouched IPC notification to the brower if the user tapped on an editable field on the page. We will be handling this notification in the browser to display the Windows 8 on screen keyboard. That in a subsequent CL. BUG=166516 R=jam Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=173601

Patch Set 1 #

Total comments: 6

Patch Set 2 : #

Patch Set 3 : #

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -0 lines)			Patch
M	chrome/renderer/chrome_render_view_observer.h	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/renderer/chrome_render_view_observer.cc	View	1	2 chunks	+13 lines, -0 lines	0 comments	Download
M	content/public/renderer/render_view_observer.h	View	1	2 chunks	+2 lines, -0 lines	0 comments	Download
M	content/renderer/render_view_impl.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

jam

lgtm https://codereview.chromium.org/11622009/diff/1/chrome/renderer/chrome_render_view_observer.cc File chrome/renderer/chrome_render_view_observer.cc (right): https://codereview.chromium.org/11622009/diff/1/chrome/renderer/chrome_render_view_observer.cc#newcode702 chrome/renderer/chrome_render_view_observer.cc:702: render_view()->GetRoutingID())); nit: indent. also here and above, you ...

8 years ago (2012-12-17 22:51:09 UTC) #2

ananta

8 years ago (2012-12-17 22:59:06 UTC) #3

https://codereview.chromium.org/11622009/diff/1/chrome/renderer/chrome_render...
File chrome/renderer/chrome_render_view_observer.cc (right):

https://codereview.chromium.org/11622009/diff/1/chrome/renderer/chrome_render...
chrome/renderer/chrome_render_view_observer.cc:702:
render_view()->GetRoutingID()));
On 2012/12/17 22:51:09, John Abd-El-Malek wrote:
> nit: indent. also here and above, you can just do routing_id() instead of
> render_view()->GetRoutingID()

Fixed this. The ChromeRenderViewObserver::DidHandleTouchEvent implementation is
being deleted in this CL https://codereview.chromium.org/11606011

https://codereview.chromium.org/11622009/diff/1/chrome/renderer/chrome_render...
File chrome/renderer/chrome_render_view_observer.h (right):

https://codereview.chromium.org/11622009/diff/1/chrome/renderer/chrome_render...
chrome/renderer/chrome_render_view_observer.h:74: OVERRIDE;
On 2012/12/17 22:51:09, John Abd-El-Malek wrote:
> nit: i believe the convention is that OVERRIDE shouldn't be at the beginning
of
> a line, so move the parameter down

Done.

https://codereview.chromium.org/11622009/diff/1/content/public/renderer/rende...
File content/public/renderer/render_view_observer.h (right):

https://codereview.chromium.org/11622009/diff/1/content/public/renderer/rende...
content/public/renderer/render_view_observer.h:93: virtual void
DidHandleGestureEvent(const WebKit::WebGestureEvent& event) {}
On 2012/12/17 22:51:09, John Abd-El-Malek wrote:
> nit: i'd move this up one line to match the other related methods

Done.

Expand Messages | Collapse Messages