Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 11606011: Delete implementation of ChromeRenderViewObserver::DidHandleTouchEvent (Closed)

Created:
8 years ago by dmazzoni
Modified:
8 years ago
Reviewers:
Rick Byers
CC:
chromium-reviews, darin-cc_chromium.org, ananta, danakj, Rick Byers, kevers, bryeung
Visibility:
Public.

Description

Delete implementation of ChromeRenderViewObserver::DidHandleTouchEvent The code was crashing, the implementation was wrong anyway, and the result was unused! This is a safe fix for M25 that just deletes the whole method implementation. Not deleting the method because Ananta already has a change in progress that reimplements it the correct way and makes use of it. BUG=162433 TBR=darin Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=174061

Patch Set 1 #

Patch Set 2 : Delete whole DidHandleTouchEvent method #

Total comments: 1

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -30 lines) Patch
M chrome/renderer/chrome_render_view_observer.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/renderer/chrome_render_view_observer.cc View 1 2 1 chunk +0 lines, -29 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
dmazzoni
8 years ago (2012-12-17 22:41:10 UTC) #1
Rick Byers
This seems fine to me, modulo the comment below. This code was originally added for ...
8 years ago (2012-12-18 19:22:57 UTC) #2
dmazzoni
FYI, Ananta just landed a change that sends ChromeViewHostMsg_FocusedEditableNodeTouched from a different method, DidHandleGestureEvent, so ...
8 years ago (2012-12-19 22:14:51 UTC) #3
Rick Byers
Thanks, lgtm You still need OWNERS though
8 years ago (2012-12-19 22:20:15 UTC) #4
dmazzoni
On 2012/12/19 22:20:15, Rick Byers wrote: > Thanks, lgtm > You still need OWNERS though ...
8 years ago (2012-12-19 22:22:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/11606011/7001
8 years ago (2012-12-19 22:22:37 UTC) #6
commit-bot: I haz the power
8 years ago (2012-12-20 00:46:59 UTC) #7
Message was sent while issue was closed.
Change committed as 174061

Powered by Google App Engine
This is Rietveld 408576698