Issue 1162173002: Add TODOs to remove AnimationPlayerEvent and AnimationPlayerEventInit

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1162173002: Add TODOs to remove AnimationPlayerEvent and AnimationPlayerEventInit (Closed)

Created:
5 years, 6 months ago by philipj_slow

Modified:
5 years, 6 months ago

Reviewers:
dstockwell

CC:
blink-reviews, shans, arv+blink, vivekg_samsung, blink-reviews-animation_chromium.org, vivekg, Inactive, darktears, rjwright, Eric Willigers

Base URL:
svn://svn.chromium.org/blink/trunk

Target Ref:
refs/remotes/origin/master

Project:
blink

Visibility:
Public.

Add TODOs to remove AnimationPlayerEvent and AnimationPlayerEventInit This was overlooked in https://codereview.chromium.org/1092203002 BUG=460722 NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196566

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -3 lines)			Patch
	M	Source/core/events/AnimationPlayerEvent.idl	View		2 chunks	+3 lines, -3 lines	0 comments	Download
	M	Source/core/events/AnimationPlayerEventInit.idl	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Total messages: 6 (2 generated)

dstockwell

lgtm Although we actually resolved to add this back https://github.com/w3c/web-animations/issues/71 But the name will need ...

5 years, 6 months ago (2015-06-05 06:29:12 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1162173002/1

5 years, 6 months ago (2015-06-05 09:43:48 UTC) #5

commit-bot: I haz the power

5 years, 6 months ago (2015-06-05 09:47:14 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196566