Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 1092203002: Document the Web Animation interfaces with spec links and TODOs (Closed)

Created:
5 years, 8 months ago by philipj_slow
Modified:
5 years, 8 months ago
Reviewers:
dstockwell
CC:
darktears, arv+blink, blink-reviews, blink-reviews-animation_chromium.org, Inactive, Eric Willigers, Mike Lawther (Google), rjwright, shans, Steve Block, Timothy Loh, vivekg_samsung, vivekg
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Document the Web Animation interfaces with spec links and TODOs Almost all of these interfaces are out of sync with the latest spec, only the two dictionaries were close enough to make it worthwhile to document the differences on a per-member level. BUG=460722 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194042

Patch Set 1 #

Total comments: 2

Patch Set 2 : adjust URLs that have been fixed in spec #

Patch Set 3 : fix a few typos #

Patch Set 4 : update as per dstockwell's feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -4 lines) Patch
M Source/core/animation/Animation.idl View 1 2 3 1 chunk +5 lines, -1 line 0 comments Download
M Source/core/animation/AnimationEffect.idl View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/core/animation/AnimationNode.idl View 1 1 chunk +6 lines, -0 lines 0 comments Download
M Source/core/animation/AnimationPlayer.idl View 1 2 3 1 chunk +6 lines, -0 lines 0 comments Download
M Source/core/animation/AnimationTimeline.idl View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/core/animation/AnimationTimingProperties.idl View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M Source/core/animation/ComputedTimingProperties.idl View 1 1 chunk +5 lines, -0 lines 0 comments Download
M Source/core/animation/DocumentAnimation.idl View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/animation/ElementAnimation.idl View 1 2 1 chunk +6 lines, -3 lines 0 comments Download
M Source/core/animation/Timing.idl View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (3 generated)
philipj_slow
PTAL. This is part of the effort to document where our IDL files don't match ...
5 years, 8 months ago (2015-04-18 21:54:25 UTC) #2
dstockwell
On 2015/04/18 at 21:54:25, philipj wrote: > PTAL. This is part of the effort to ...
5 years, 8 months ago (2015-04-20 05:42:34 UTC) #3
philipj_slow
On 2015/04/20 05:42:34, dstockwell wrote: > On 2015/04/18 at 21:54:25, philipj wrote: > > PTAL. ...
5 years, 8 months ago (2015-04-20 09:07:56 UTC) #4
philipj_slow
adjust URLs that have been fixed in spec
5 years, 8 months ago (2015-04-20 13:10:53 UTC) #5
philipj_slow
fix a few typos
5 years, 8 months ago (2015-04-20 13:14:26 UTC) #6
dstockwell
Trying to send comments again... https://codereview.chromium.org/1092203002/diff/1/Source/core/animation/Animation.idl File Source/core/animation/Animation.idl (right): https://codereview.chromium.org/1092203002/diff/1/Source/core/animation/Animation.idl#newcode34 Source/core/animation/Animation.idl:34: // https://w3c.github.io/web-animations/#the-animation-interface This is ...
5 years, 8 months ago (2015-04-20 13:32:24 UTC) #7
philipj_slow
update as per dstockwell's feedback
5 years, 8 months ago (2015-04-20 15:17:14 UTC) #8
philipj_slow
Thanks, I've updated those two comments to be more accurate and skipped mentioning EventTarget. Landing ...
5 years, 8 months ago (2015-04-20 15:17:54 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1092203002/50001
5 years, 8 months ago (2015-04-20 15:18:34 UTC) #12
commit-bot: I haz the power
5 years, 8 months ago (2015-04-20 18:11:39 UTC) #13
Message was sent while issue was closed.
Committed patchset #4 (id:50001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194042

Powered by Google App Engine
This is Rietveld 408576698