Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issue 1162163003: [turbofan] Specify better type for FixedArray::length field. (Closed)

Created:
5 years, 6 months ago by Benedikt Meurer
Modified:
5 years, 6 months ago
Reviewers:
Jarin
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Specify better type for FixedArray::length field. This avoids redundant smi checks when using the length of a FixedArray, which is always a positve smi. R=jarin@chromium.org Committed: https://crrev.com/298cb97652ce80acc53379907ec0766775aa74eb Cr-Commit-Position: refs/heads/master@{#28746}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M src/compiler/access-builder.cc View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
Benedikt Meurer
5 years, 6 months ago (2015-06-02 04:01:30 UTC) #1
Jarin
lgtm
5 years, 6 months ago (2015-06-02 06:14:46 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1162163003/1
5 years, 6 months ago (2015-06-02 06:15:10 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-02 06:18:27 UTC) #5
commit-bot: I haz the power
5 years, 6 months ago (2015-06-02 06:18:42 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/298cb97652ce80acc53379907ec0766775aa74eb
Cr-Commit-Position: refs/heads/master@{#28746}

Powered by Google App Engine
This is Rietveld 408576698