Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(695)

Side by Side Diff: src/compiler/access-builder.cc

Issue 1162163003: [turbofan] Specify better type for FixedArray::length field. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler/access-builder.h" 5 #include "src/compiler/access-builder.h"
6 #include "src/types-inl.h" 6 #include "src/types-inl.h"
7 7
8 namespace v8 { 8 namespace v8 {
9 namespace internal { 9 namespace internal {
10 namespace compiler { 10 namespace compiler {
(...skipping 28 matching lines...) Expand all
39 39
40 // static 40 // static
41 FieldAccess AccessBuilder::ForJSArrayBufferBackingStore() { 41 FieldAccess AccessBuilder::ForJSArrayBufferBackingStore() {
42 return {kTaggedBase, JSArrayBuffer::kBackingStoreOffset, MaybeHandle<Name>(), 42 return {kTaggedBase, JSArrayBuffer::kBackingStoreOffset, MaybeHandle<Name>(),
43 Type::UntaggedPointer(), kMachPtr}; 43 Type::UntaggedPointer(), kMachPtr};
44 } 44 }
45 45
46 46
47 // static 47 // static
48 FieldAccess AccessBuilder::ForFixedArrayLength() { 48 FieldAccess AccessBuilder::ForFixedArrayLength() {
49 // TODO(turbofan): 2^30 is a valid upper limit for the FixedArray::length
50 // field, although it's not the best. If we had a Zone we could create an
51 // appropriate range type instead.
52 STATIC_ASSERT(FixedArray::kMaxLength <= 1 << 30);
49 return {kTaggedBase, FixedArray::kLengthOffset, MaybeHandle<Name>(), 53 return {kTaggedBase, FixedArray::kLengthOffset, MaybeHandle<Name>(),
50 Type::TaggedSigned(), kMachAnyTagged}; 54 Type::Intersect(Type::Unsigned30(), Type::TaggedSigned()),
55 kMachAnyTagged};
51 } 56 }
52 57
53 58
54 // static 59 // static
55 FieldAccess AccessBuilder::ForExternalArrayPointer() { 60 FieldAccess AccessBuilder::ForExternalArrayPointer() {
56 return {kTaggedBase, ExternalArray::kExternalPointerOffset, 61 return {kTaggedBase, ExternalArray::kExternalPointerOffset,
57 MaybeHandle<Name>(), Type::UntaggedPointer(), kMachPtr}; 62 MaybeHandle<Name>(), Type::UntaggedPointer(), kMachPtr};
58 } 63 }
59 64
60 65
(...skipping 127 matching lines...) Expand 10 before | Expand all | Expand 10 after
188 193
189 // static 194 // static
190 FieldAccess AccessBuilder::ForSharedFunctionInfoTypeFeedbackVector() { 195 FieldAccess AccessBuilder::ForSharedFunctionInfoTypeFeedbackVector() {
191 return {kTaggedBase, SharedFunctionInfo::kFeedbackVectorOffset, 196 return {kTaggedBase, SharedFunctionInfo::kFeedbackVectorOffset,
192 Handle<Name>(), Type::Any(), kMachAnyTagged}; 197 Handle<Name>(), Type::Any(), kMachAnyTagged};
193 } 198 }
194 199
195 } // namespace compiler 200 } // namespace compiler
196 } // namespace internal 201 } // namespace internal
197 } // namespace v8 202 } // namespace v8
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698