Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Issue 1162043008: Revert of Implement %TypedArray%.prototype.{reduce,reduceRight} (Closed)

Created:
5 years, 6 months ago by Benedikt Meurer
Modified:
5 years, 6 months ago
Reviewers:
adamk, dehrenberg
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Implement %TypedArray%.prototype.{reduce,reduceRight} (patchset #3 id:40001 of https://codereview.chromium.org/1154423014/) Reason for revert: Breaks Win32 mjsunit/harmony/typedarray-reduce, see http://build.chromium.org/p/client.v8/builders/V8%20Win32%20-%20nosnap%20-%20shared/builds/7121/steps/Check/logs/typedarray-reduce for details. Original issue's description: > Implement %TypedArray%.prototype.{reduce,reduceRight} > > This patch implements the last two methods on TypedArrays. These > were previously committed and led to a test failure. > > BUG=v8:3578 > LOG=Y > R=adamk > > Committed: https://crrev.com/95d779ecc9816ac20c1565bebeeac6a1ef29f1c7 > Cr-Commit-Position: refs/heads/master@{#28773} TBR=adamk@chromium.org,dehrenberg@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:3578 Committed: https://crrev.com/b104a67ef0a50beab2dc85a6ac5732c696d07698 Cr-Commit-Position: refs/heads/master@{#28777}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -315 lines) Patch
M src/array.js View 4 chunks +16 lines, -29 lines 0 comments Download
M src/harmony-typedarray.js View 4 chunks +0 lines, -28 lines 0 comments Download
M src/prologue.js View 1 chunk +0 lines, -2 lines 0 comments Download
D test/mjsunit/harmony/typedarray-reduce.js View 1 chunk +0 lines, -256 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Benedikt Meurer
Created Revert of Implement %TypedArray%.prototype.{reduce,reduceRight}
5 years, 6 months ago (2015-06-03 05:29:01 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1162043008/1
5 years, 6 months ago (2015-06-03 05:29:22 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-03 05:29:35 UTC) #3
commit-bot: I haz the power
5 years, 6 months ago (2015-06-03 05:29:52 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b104a67ef0a50beab2dc85a6ac5732c696d07698
Cr-Commit-Position: refs/heads/master@{#28777}

Powered by Google App Engine
This is Rietveld 408576698