Implement %TypedArray%.prototype.{reduce,reduceRight}

Implement %TypedArray%.prototype.{reduce,reduceRight}

This patch implements the last two methods on TypedArrays. These
were previously committed and led to a test failure.

BUG=v8:3578
LOG=Y
R=adamk

Committed: https://crrev.com/95d779ecc9816ac20c1565bebeeac6a1ef29f1c7
Cr-Commit-Position: refs/heads/master@{#28773}

[dehrenberg, 2015-06-02 15:20:42]

This has been submitted before, and the patch here is just a rebase. It was
rolled back for a test failure that I don't understand; Jochen ran the test
himself and failed to reproduce it. If the rebase looks good to you, let's
submit it again and roll it back if continuous integration finds the error
again.

[dehrenberg, 2015-06-02 17:10:42]

The CQ bit was checked by dehrenberg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-06-02 17:11:28]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1154423014/1

[commit-bot: I haz the power, 2015-06-02 17:11:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-02 17:11:31]

Dry run: No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[adamk, 2015-06-02 18:28:14]

lgtm % test nit

https://codereview.chromium.org/1154423014/diff/1/test/mjsunit/harmony/typeda...
File test/mjsunit/harmony/typedarray-reduce.js (right):

https://codereview.chromium.org/1154423014/diff/1/test/mjsunit/harmony/typeda...
test/mjsunit/harmony/typedarray-reduce.js:5: // Flags: --harmony-arrays
--allow-natives-syntax
Doesn't look like you need --allow-native-syntax here?

[dehrenberg, 2015-06-02 22:44:24]

https://codereview.chromium.org/1154423014/diff/1/test/mjsunit/harmony/typeda...
File test/mjsunit/harmony/typedarray-reduce.js (right):

https://codereview.chromium.org/1154423014/diff/1/test/mjsunit/harmony/typeda...
test/mjsunit/harmony/typedarray-reduce.js:5: // Flags: --harmony-arrays
--allow-natives-syntax
On 2015/06/02 18:28:14, adamk wrote:
> Doesn't look like you need --allow-native-syntax here?

Done.

[dehrenberg, 2015-06-02 22:44:30]

The CQ bit was checked by dehrenberg@chromium.org

[dehrenberg, 2015-06-02 22:44:31]

The patchset sent to the CQ was uploaded after l-g-t-m from adamk@chromium.org
Link to the patchset: https://codereview.chromium.org/1154423014/#ps20001
(title: "Fix test flagwq")

[commit-bot: I haz the power, 2015-06-02 22:45:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1154423014/20001

[commit-bot: I haz the power, 2015-06-02 22:46:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-02 22:46:50]

Try jobs failed on following builders:
  v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/967)

[dehrenberg, 2015-06-02 22:56:34]

The CQ bit was checked by dehrenberg@chromium.org

[dehrenberg, 2015-06-02 22:56:35]

The patchset sent to the CQ was uploaded after l-g-t-m from adamk@chromium.org
Link to the patchset: https://codereview.chromium.org/1154423014/#ps40001
(title: "rebase")

[commit-bot: I haz the power, 2015-06-02 22:57:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1154423014/40001

[commit-bot: I haz the power, 2015-06-03 05:01:37]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-06-03 05:01:49]

Patchset 3 (id:??) landed as
https://crrev.com/95d779ecc9816ac20c1565bebeeac6a1ef29f1c7
Cr-Commit-Position: refs/heads/master@{#28773}

[Benedikt Meurer, 2015-06-03 05:29:01]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1162043008/ by bmeurer@chromium.org.

The reason for reverting is: Breaks Win32 mjsunit/harmony/typedarray-reduce, see
http://build.chromium.org/p/client.v8/builders/V8%20Win32%20-%20nosnap%20-%20...
for details..

[adamk, 2015-06-04 01:03:14]

I managed to reproduce this locally.

It might be related to https://code.google.com/p/v8/issues/detail?id=3815

And it definitely seems unrelated to typed arrays, so if you modify the test to
avoid using a property whose key is NaN you should be good.

https://codereview.chromium.org/1154423014/diff/40001/test/mjsunit/harmony/ty...
File test/mjsunit/harmony/typedarray-reduce.js (right):

https://codereview.chromium.org/1154423014/diff/40001/test/mjsunit/harmony/ty...
test/mjsunit/harmony/typedarray-reduce.js:170: arrayPlus[NaN] = NaN;
If I comment out this line the test passes.