Issue 1161983004: Refactor layout/relayout into a single method.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1161983004: Refactor layout/relayout into a single method. (Closed)

Created:
5 years, 6 months ago by Hixie

Modified:
5 years, 6 months ago

Reviewers:
abarth-chromium

CC:
abarth-chromium, gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Refactor layout/relayout into a single method. This dramatically simplifies the layout model. I haven't gone through and simplified the existing functions, we should probably go through and figure out if they can be cleaned up a bit. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/3455f3c0e1f387ae422be3b5c3058ddaa700f640

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+125 lines, -215 lines)			Patch
M	sky/examples/raw/sector-layout.dart	View	8 chunks	+20 lines, -48 lines	0 comments	Download
M	sky/examples/raw/simple_render_tree.dart	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	sky/sdk/lib/framework/app.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sky/sdk/lib/framework/components2/scaffold.dart	View	3 chunks	+3 lines, -4 lines	0 comments	Download
M	sky/sdk/lib/framework/fn2.dart	View	2 chunks	+2 lines, -3 lines	0 comments	Download
M	sky/sdk/lib/framework/layout2.dart	View	15 chunks	+98 lines, -157 lines	0 comments	Download

Total messages: 3 (1 generated)

Hixie

5 years, 6 months ago (2015-05-28 18:16:04 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
3455f3c0e1f387ae422be3b5c3058ddaa700f640 (presubmit successful).