Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(698)

Unified Diff: sky/sdk/lib/framework/fn2.dart

Issue 1161983004: Refactor layout/relayout into a single method. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/sdk/lib/framework/components2/scaffold.dart ('k') | sky/sdk/lib/framework/layout2.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/sdk/lib/framework/fn2.dart
diff --git a/sky/sdk/lib/framework/fn2.dart b/sky/sdk/lib/framework/fn2.dart
index a83535857bbe69f40d63e7c73b6169cb15a69855..ef76a543c56702c6314713396bfe02d8b9ab99e3 100644
--- a/sky/sdk/lib/framework/fn2.dart
+++ b/sky/sdk/lib/framework/fn2.dart
@@ -564,7 +564,7 @@ class Paragraph extends OneChildListRenderNodeWrapper {
class FlexContainer extends OneChildListRenderNodeWrapper {
RenderFlex root;
- RenderFlex createNode() => new RenderFlex(this, this.direction);
+ RenderFlex createNode() => new RenderFlex(direction: this.direction);
static final FlexContainer _emptyContainer = new FlexContainer();
// direction doesn't matter if it's empty
@@ -958,10 +958,9 @@ class RenderSolidColor extends RenderDecoratedBox {
width: desiredWidth);
}
- void layout(BoxConstraints constraints, { RenderNode relayoutSubtreeRoot }) {
+ void performLayout() {
width = constraints.constrainWidth(desiredWidth);
height = constraints.constrainHeight(desiredHeight);
- layoutDone();
}
void handlePointer(sky.PointerEvent event) {
« no previous file with comments | « sky/sdk/lib/framework/components2/scaffold.dart ('k') | sky/sdk/lib/framework/layout2.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698