Follow up for issue 490583 for changing histogram name and enum name for notification..

Follow up for issue 490583 for changing histogram name and enum name.

BUG=493147
Committed: https://crrev.com/9156b16dac27cb5850a0d8f23a6aefd6f0e860d2
Cr-Commit-Position: refs/heads/master@{#331961}

[Deepak, 2015-05-28 14:55:48]

deepak.m1@samsung.com changed reviewers:
+ asvitkine@chromium.org, peter@chromium.org

[Deepak, 2015-05-28 14:55:48]

This is follow up patch to address changing histogram name and enum name for
Notification, as @peter suggested.
PTAL

[Peter Beverloo, 2015-05-28 15:00:29]

lgtm, thank you!

[Alexei Svitkine (slow), 2015-05-28 15:02:14]

lgtm

[Deepak, 2015-05-28 15:03:52]

On 2015/05/28 15:02:14, Alexei Svitkine wrote:
> lgtm

Thanks @peter and @asvitkine.

[Deepak, 2015-05-28 15:03:58]

The CQ bit was checked by deepak.m1@samsung.com

[commit-bot: I haz the power, 2015-05-28 15:04:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1161983002/1

[commit-bot: I haz the power, 2015-05-28 16:01:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-28 16:01:41]

Failed to apply patch for tools/metrics/histograms/histograms.xml:
While running git apply --index -3 -p1;
  error: patch failed: tools/metrics/histograms/histograms.xml:36452
  Falling back to three-way merge...
  Applied patch to 'tools/metrics/histograms/histograms.xml' with conflicts.
  U tools/metrics/histograms/histograms.xml

Patch:       tools/metrics/histograms/histograms.xml
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml
b/tools/metrics/histograms/histograms.xml
index
3b8cb6a73d0d2d37c9b945b40a745d5d9f21c57a..cea4fa050fd3219aa28784b922c2afde6eba1f8a
100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -25680,6 +25680,27 @@ Therefore, the affected-histogram name has to have at
least one dot in it.
   </summary>
 </histogram>
 
+<histogram name="Notifications.PersistentNotificationDataDeleted"
+    enum="BooleanSuccess">
+  <owner>peter@chromium.org</owner>
+  <owner>deepak.m1@samsung.com</owner>
+  <summary>
+    Recorded when the data associated with a persistent Web Notification gets
+    deleted. The value will be true if data deletion succeeded, and false if
+    there was an error.
+  </summary>
+</histogram>
+
+<histogram name="Notifications.PersistentWebNotificationClickResult"
+    enum="PlatformNotificationStatus">
+  <owner>peter@chromium.org</owner>
+  <owner>deepak.m1@samsumg.com</owner>
+  <summary>
+    Recorded delivery status for persistent notification clicks to a Service
+    Worker when handling a click on a persistent WebNotification has finished.
+  </summary>
+</histogram>
+
 <histogram name="NQE.FastestRTT" units="milliseconds">
   <owner>tbansal@chromium.org</owner>
   <summary>
@@ -36452,29 +36473,6 @@ Therefore, the affected-histogram name has to have at
least one dot in it.
   </summary>
 </histogram>
 
-<histogram
-   
name="ServiceWorker.PlatformNotificationService.PersistentNotificationDataDeleted"
-    enum="BooleanSuccess">
-  <owner>peter@chromium.org</owner>
-  <owner>deepak.m1@samsung.com</owner>
-  <summary>
-    Recorded when the data associated with a persistent Web Notification gets
-    deleted. The value will be true if data deletion succeeded, and false if
-    there was an error.
-  </summary>
-</histogram>
-
-<histogram
-   
name="ServiceWorker.PlatformNotificationService.PersistentWebNotificationClickResult"
-    enum="ServiceWorkerPlatformNotificationStatus">
-  <owner>peter@chromium.org</owner>
-  <owner>deepak.m1@samsumg.com</owner>
-  <summary>
-    Recorded delivery status for persistent notification clicks to a Service
-    Worker when handling a click on a persistent WebNotification has finished.
-  </summary>
-</histogram>
-
 <histogram name="ServiceWorker.PushEventExecutionTime" units="millisecond">
   <owner>johnme@chromium.org</owner>
   <summary>Execution time of ServiceWorkerGlobalScope.onpush.</summary>
@@ -61122,6 +61120,14 @@ To add a new entry, add it with any value and run test
to compute valid value.
   <int value="16" label="I/O"/>
 </enum>
 
+<enum name="PlatformNotificationStatus" type="int">
+  <int value="0" label="OK"/>
+  <int value="1" label="Service Worker not found"/>
+  <int value="2" label="Service Worker error"/>
+  <int value="3" label="event.waitUntil promise rejected"/>
+  <int value="4" label="Database error"/>
+</enum>
+
 <enum name="PluginAvailabilityStatus" type="int">
   <int value="0" label="PLUGIN_NOT_REGISTERED"/>
   <int value="1" label="PLUGIN_AVAILABLE"/>
@@ -63589,14 +63595,6 @@ To add a new entry, add it with any value and run test
to compute valid value.
   <int value="2" label="Failed to delete ServiceWorkerDiskCache"/>
 </enum>
 
-<enum name="ServiceWorkerPlatformNotificationStatus" type="int">
-  <int value="0" label="OK"/>
-  <int value="1" label="Service Worker not found"/>
-  <int value="2" label="Service Worker error"/>
-  <int value="3" label="event.waitUntil promise rejected"/>
-  <int value="4" label="Database error"/>
-</enum>
-
 <enum name="ServiceWorkerReadResponseResult" type="int">
   <int value="0" label="OK"/>
   <int value="1" label="Read headers error"/>

[commit-bot: I haz the power, 2015-05-28 16:02:32]

The CQ bit was unchecked by commit-bot@chromium.org

[Deepak, 2015-05-29 03:55:04]

The CQ bit was checked by deepak.m1@samsung.com

[Deepak, 2015-05-29 03:55:04]

The patchset sent to the CQ was uploaded after l-g-t-m from peter@chromium.org,
asvitkine@chromium.org
Link to the patchset: https://codereview.chromium.org/1161983002/#ps20001
(title: "Resolving build issues.")

[commit-bot: I haz the power, 2015-05-29 03:55:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1161983002/20001

[commit-bot: I haz the power, 2015-05-29 04:31:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-29 04:31:20]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Deepak, 2015-05-29 06:27:48]

The CQ bit was checked by deepak.m1@samsung.com

[commit-bot: I haz the power, 2015-05-29 06:28:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1161983002/20001

[commit-bot: I haz the power, 2015-05-29 07:05:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-29 07:05:48]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Deepak, 2015-05-29 07:47:08]

On 2015/05/29 07:05:48, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux
(JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

compilation is getting failed with and without my patch and at the same place 
ui/ozone/demo/gl_renderer.cc:56:35
if (!surface_->SwapBuffersAsync(base::Bind(&GlRenderer::PostRenderFrameTask,
                                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../base/callback.h:358:7: note: candidate constructor (the implicit move
constructor) not viable: no known conversion from 'base::Callback<typename
internal::BindState<typename internal::FunctorTraits<void
(GlRenderer::*)()>::RunnableType, typename internal::FunctorTraits<void
(GlRenderer::*)()>::RunType, internal::TypeList<typename
internal::CallbackParamTraits<WeakPtr<GlRenderer> >::StorageType>
>::UnboundRunType>' to 'base::Callback<void (gfx::SwapResult)> &&' for 1st
argument
class Callback;

That is unrelated to my changes.

[Peter Beverloo, 2015-05-29 09:27:25]

The CQ bit was checked by peter@chromium.org

[commit-bot: I haz the power, 2015-05-29 09:27:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1161983002/20001

[commit-bot: I haz the power, 2015-05-29 09:57:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-29 09:57:38]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Deepak, 2015-05-29 13:14:12]

The CQ bit was checked by deepak.m1@samsung.com

[commit-bot: I haz the power, 2015-05-29 13:15:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1161983002/20001

[commit-bot: I haz the power, 2015-05-29 13:53:20]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-05-29 13:54:25]

Patchset 2 (id:??) landed as
https://crrev.com/9156b16dac27cb5850a0d8f23a6aefd6f0e860d2
Cr-Commit-Position: refs/heads/master@{#331961}