Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Unified Diff: tools/metrics/histograms/histograms.xml

Issue 1161983002: Follow up for issue 490583 for changing histogram name and enum name for notification.. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Resolving build issues. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « chrome/browser/notifications/platform_notification_service_impl.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index ec03e58ec6d168eb277dc84930a1802f28dd51b0..2e00f7543adff32c45ac33de306d1e2e8e81547e 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -25716,6 +25716,27 @@ Therefore, the affected-histogram name has to have at least one dot in it.
</summary>
</histogram>
+<histogram name="Notifications.PersistentNotificationDataDeleted"
+ enum="BooleanSuccess">
+ <owner>peter@chromium.org</owner>
+ <owner>deepak.m1@samsung.com</owner>
+ <summary>
+ Recorded when the data associated with a persistent Web Notification gets
+ deleted. The value will be true if data deletion succeeded, and false if
+ there was an error.
+ </summary>
+</histogram>
+
+<histogram name="Notifications.PersistentWebNotificationClickResult"
+ enum="PlatformNotificationStatus">
+ <owner>peter@chromium.org</owner>
+ <owner>deepak.m1@samsumg.com</owner>
+ <summary>
+ Recorded delivery status for persistent notification clicks to a Service
+ Worker when handling a click on a persistent WebNotification has finished.
+ </summary>
+</histogram>
+
<histogram name="NQE.FastestRTT" units="milliseconds">
<owner>tbansal@chromium.org</owner>
<summary>
@@ -36579,29 +36600,6 @@ Therefore, the affected-histogram name has to have at least one dot in it.
</summary>
</histogram>
-<histogram
- name="ServiceWorker.PlatformNotificationService.PersistentNotificationDataDeleted"
- enum="BooleanSuccess">
- <owner>peter@chromium.org</owner>
- <owner>deepak.m1@samsung.com</owner>
- <summary>
- Recorded when the data associated with a persistent Web Notification gets
- deleted. The value will be true if data deletion succeeded, and false if
- there was an error.
- </summary>
-</histogram>
-
-<histogram
- name="ServiceWorker.PlatformNotificationService.PersistentWebNotificationClickResult"
- enum="ServiceWorkerPlatformNotificationStatus">
- <owner>peter@chromium.org</owner>
- <owner>deepak.m1@samsumg.com</owner>
- <summary>
- Recorded delivery status for persistent notification clicks to a Service
- Worker when handling a click on a persistent WebNotification has finished.
- </summary>
-</histogram>
-
<histogram name="ServiceWorker.PushEvent.Time" units="milliseconds">
<owner>johnme@chromium.org</owner>
<summary>
@@ -61308,6 +61306,14 @@ To add a new entry, add it with any value and run test to compute valid value.
<int value="16" label="I/O"/>
</enum>
+<enum name="PlatformNotificationStatus" type="int">
+ <int value="0" label="OK"/>
+ <int value="1" label="Service Worker not found"/>
+ <int value="2" label="Service Worker error"/>
+ <int value="3" label="event.waitUntil promise rejected"/>
+ <int value="4" label="Database error"/>
+</enum>
+
<enum name="PluginAvailabilityStatus" type="int">
<int value="0" label="PLUGIN_NOT_REGISTERED"/>
<int value="1" label="PLUGIN_AVAILABLE"/>
@@ -63775,14 +63781,6 @@ To add a new entry, add it with any value and run test to compute valid value.
<int value="2" label="Failed to delete ServiceWorkerDiskCache"/>
</enum>
-<enum name="ServiceWorkerPlatformNotificationStatus" type="int">
- <int value="0" label="OK"/>
- <int value="1" label="Service Worker not found"/>
- <int value="2" label="Service Worker error"/>
- <int value="3" label="event.waitUntil promise rejected"/>
- <int value="4" label="Database error"/>
-</enum>
-
<enum name="ServiceWorkerReadResponseResult" type="int">
<int value="0" label="OK"/>
<int value="1" label="Read headers error"/>
« no previous file with comments | « chrome/browser/notifications/platform_notification_service_impl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698