chrome/browser/ui/views/profiles/profile_chooser_view.cc - Issue 1161973002: Regression: Overlay for "you' re now signed into chrome" remains open after clicking on 'settings' …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/profiles/profile_chooser_view.cc

Issue 1161973002: Regression: Overlay for "you' re now signed into chrome" remains open after clicking on 'settings' … (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase before landing Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/views/profiles/profile_chooser_view.cc

diff --git a/chrome/browser/ui/views/profiles/profile_chooser_view.cc b/chrome/browser/ui/views/profiles/profile_chooser_view.cc

index 14c9241c639c3b66443a939aaa47ce828104631b..7fa8d8ef539ca26211ca2e372b16123d04bc493d 100644

--- a/chrome/browser/ui/views/profiles/profile_chooser_view.cc

+++ b/chrome/browser/ui/views/profiles/profile_chooser_view.cc

@@ -872,6 +872,7 @@ void ProfileChooserView::LinkClicked(views::Link* sender, int event_flags) {

tutorial_mode_ = profiles::TUTORIAL_MODE_NONE;

ProfileMetrics::LogProfileNewAvatarMenuSignin(

ProfileMetrics::PROFILE_AVATAR_MENU_SIGNIN_SETTINGS);

+ profile_bubble_->Hide();

msw 2015/06/05 19:51:47 nit: Just call Hide() (the static ProfileChooserVi

} else if (sender == tutorial_not_you_link_) {

ProfileMetrics::LogProfileNewAvatarMenuUpgrade(

ProfileMetrics::PROFILE_AVATAR_MENU_UPGRADE_NOT_YOU);

« no previous file with comments | « chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm ('k') | no next file » | no next file with comments »