chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm - Issue 1161973002: Regression: Overlay for "you' re now signed into chrome" remains open after clicking on 'settings' …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm

Issue 1161973002: Regression: Overlay for "you' re now signed into chrome" remains open after clicking on 'settings' … (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase before landing Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm

diff --git a/chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm b/chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm

index 4c00e6e6a9a7c153ff6cfe67622fe1312145f7f4..9e6140c56bd0574c99b76ad9cf288a8421765007 100644

--- a/chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm

+++ b/chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm

@@ -1121,6 +1121,7 @@ class ActiveProfileObserverBridge : public AvatarMenuObserver,

SyncConfirmationUIClosed(true);

ProfileMetrics::LogProfileNewAvatarMenuSignin(

ProfileMetrics::PROFILE_AVATAR_MENU_SIGNIN_SETTINGS);

+ [self close];

}

- (IBAction)syncSettingsConfirmed:(id)sender {

« no previous file with comments | « no previous file | chrome/browser/ui/views/profiles/profile_chooser_view.cc » ('j') | chrome/browser/ui/views/profiles/profile_chooser_view.cc » ('J')