Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Issue 1161943005: Add a note about false positives on "copyright" word into licenses checker (Closed)

Created:
5 years, 6 months ago by mnaganov (inactive)
Modified:
5 years, 6 months ago
Reviewers:
Torne
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a note about false positives on "copyright" word into licenses checker It is required to scan the entire file for potential copyright references, as third-party code may appear anywhere in the file, so false positives are unfortunately inevitable for comments containing the "C-word". Add a note to the scanner message to provide a hint on that. BUG=243570 TBR=torne@chromium.org Committed: https://crrev.com/6508758837638553b83bcef6602e9b6bb9e52e95 Cr-Commit-Position: refs/heads/master@{#333124}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -4 lines) Patch
M android_webview/tools/copyright_scanner.py View 1 chunk +5 lines, -2 lines 0 comments Download
M android_webview/tools/webview_licenses.py View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
mnaganov (inactive)
TBR'ing as it's only a change in the text of messages.
5 years, 6 months ago (2015-06-05 20:29:50 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1161943005/1
5 years, 6 months ago (2015-06-05 20:30:33 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-05 20:48:10 UTC) #4
commit-bot: I haz the power
5 years, 6 months ago (2015-06-05 20:49:02 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6508758837638553b83bcef6602e9b6bb9e52e95
Cr-Commit-Position: refs/heads/master@{#333124}

Powered by Google App Engine
This is Rietveld 408576698