Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Unified Diff: android_webview/tools/copyright_scanner.py

Issue 1161943005: Add a note about false positives on "copyright" word into licenses checker (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | android_webview/tools/webview_licenses.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/tools/copyright_scanner.py
diff --git a/android_webview/tools/copyright_scanner.py b/android_webview/tools/copyright_scanner.py
index fb403fdeaaf24fc67131f7ef8d233f4d484efa99..0c6b3a9fe226037d9befb1975d0b5295aaf1a6d0 100644
--- a/android_webview/tools/copyright_scanner.py
+++ b/android_webview/tools/copyright_scanner.py
@@ -376,8 +376,11 @@ def ScanAtPresubmit(input_api, output_api):
results.append(output_api.PresubmitError(
'The following files contain a third-party license but are not in ' \
'a listed third-party directory and are not whitelisted. You must ' \
- 'add the following files to the whitelist file ' \
- '%s:' % _GetWhitelistFileName(input_api),
+ 'add the following files to the whitelist file %s\n' \
+ '(Note that if the code you are adding does not actually contain ' \
+ 'any third-party code, it may contain the word "copyright", which ' \
+ 'should be masked out, e.g. by writing it as "copy-right"):' \
+ '' % _GetWhitelistFileName(input_api),
sorted(unknown_files)))
if missing_files:
results.append(output_api.PresubmitPromptWarning(
« no previous file with comments | « no previous file | android_webview/tools/webview_licenses.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698