Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 1161643003: [arm64] Use ubfiz in ARM64 instruction selector (Closed)

Created:
5 years, 6 months ago by martyn.capewell
Modified:
5 years, 6 months ago
Reviewers:
Benedikt Meurer, ulan
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[arm64] Use ubfiz in ARM64 instruction selector Select ubfiz for (x & mask) << imm where mask is contiguous and imm is non-zero. BUG= Committed: https://crrev.com/afd0367f5d219014433cb2dc1d84c50fa8196eac Cr-Commit-Position: refs/heads/master@{#28755}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -0 lines) Patch
M src/compiler/arm64/code-generator-arm64.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/compiler/arm64/instruction-codes-arm64.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/arm64/instruction-selector-arm64.cc View 1 chunk +32 lines, -0 lines 0 comments Download
M test/unittests/compiler/arm64/instruction-selector-arm64-unittest.cc View 1 chunk +34 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
martyn.capewell
5 years, 6 months ago (2015-06-02 10:01:37 UTC) #2
Benedikt Meurer
lgtm
5 years, 6 months ago (2015-06-02 10:14:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1161643003/1
5 years, 6 months ago (2015-06-02 10:14:26 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-02 10:57:43 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-02 10:57:56 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/afd0367f5d219014433cb2dc1d84c50fa8196eac
Cr-Commit-Position: refs/heads/master@{#28755}

Powered by Google App Engine
This is Rietveld 408576698