Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issue 1161643002: Reorder across clears (Closed)

Created:
5 years, 7 months ago by joshua.litt
Modified:
5 years, 7 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : tweaks #

Patch Set 3 : more #

Patch Set 4 : more #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -7 lines) Patch
M src/gpu/GrCommandBuilder.cpp View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M src/gpu/GrReorderCommandBuilder.cpp View 1 2 3 2 chunks +12 lines, -1 line 0 comments Download
M src/gpu/GrTargetCommands.h View 1 2 2 chunks +7 lines, -6 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
joshualitt
I know we've talked about adding clears to GrBatch, so perhaps this is just for ...
5 years, 7 months ago (2015-05-26 14:56:07 UTC) #2
bsalomon
lgtm if we skip the reorder when the canignorerect bit is set.
5 years, 7 months ago (2015-05-26 15:27:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1161643002/20001
5 years, 7 months ago (2015-05-26 15:34:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1161643002/60001
5 years, 7 months ago (2015-05-26 16:27:33 UTC) #10
commit-bot: I haz the power
5 years, 7 months ago (2015-05-26 16:33:53 UTC) #11
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/36ec383c579066520357605eb8726193f251187e

Powered by Google App Engine
This is Rietveld 408576698