Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Side by Side Diff: src/gpu/GrReorderCommandBuilder.cpp

Issue 1161643002: Reorder across clears (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: more Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/gpu/GrCommandBuilder.cpp ('k') | src/gpu/GrTargetCommands.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2015 Google Inc. 2 * Copyright 2015 Google Inc.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license that can be 4 * Use of this source code is governed by a BSD-style license that can be
5 * found in the LICENSE file. 5 * found in the LICENSE file.
6 */ 6 */
7 7
8 #include "GrReorderCommandBuilder.h" 8 #include "GrReorderCommandBuilder.h"
9 9
10 static bool intersect(const SkRect& a, const SkRect& b) { 10 template <class Left, class Right>
11 static bool intersect(const Left& a, const Right& b) {
11 SkASSERT(a.fLeft <= a.fRight && a.fTop <= a.fBottom && 12 SkASSERT(a.fLeft <= a.fRight && a.fTop <= a.fBottom &&
12 b.fLeft <= b.fRight && b.fTop <= b.fBottom); 13 b.fLeft <= b.fRight && b.fTop <= b.fBottom);
13 return a.fLeft < b.fRight && b.fLeft < a.fRight && 14 return a.fLeft < b.fRight && b.fLeft < a.fRight &&
14 a.fTop < b.fBottom && b.fTop < a.fBottom; 15 a.fTop < b.fBottom && b.fTop < a.fBottom;
15 } 16 }
16 17
17 GrTargetCommands::Cmd* GrReorderCommandBuilder::recordDrawBatch(State* state, Gr Batch* batch) { 18 GrTargetCommands::Cmd* GrReorderCommandBuilder::recordDrawBatch(State* state, Gr Batch* batch) {
18 // Check if there is a Batch Draw we can batch with by linearly searching ba ck until we either 19 // Check if there is a Batch Draw we can batch with by linearly searching ba ck until we either
19 // 1) check every draw 20 // 1) check every draw
20 // 2) intersect with something 21 // 2) intersect with something
21 // 3) find a 'blocker' 22 // 3) find a 'blocker'
22 // Experimentally we have found that most batching occurs within the first 1 0 comparisons. 23 // Experimentally we have found that most batching occurs within the first 1 0 comparisons.
23 static const int kMaxLookback = 10; 24 static const int kMaxLookback = 10;
24 int i = 0; 25 int i = 0;
25 if (!this->cmdBuffer()->empty()) { 26 if (!this->cmdBuffer()->empty()) {
26 GrTargetCommands::CmdBuffer::ReverseIter reverseIter(*this->cmdBuffer()) ; 27 GrTargetCommands::CmdBuffer::ReverseIter reverseIter(*this->cmdBuffer()) ;
27 28
28 do { 29 do {
29 if (Cmd::kDrawBatch_CmdType == reverseIter->type()) { 30 if (Cmd::kDrawBatch_CmdType == reverseIter->type()) {
30 DrawBatch* previous = static_cast<DrawBatch*>(reverseIter.get()) ; 31 DrawBatch* previous = static_cast<DrawBatch*>(reverseIter.get()) ;
31 32
32 if (previous->fState->getPipeline()->isEqual(*state->getPipeline ()) && 33 if (previous->fState->getPipeline()->isEqual(*state->getPipeline ()) &&
33 previous->fBatch->combineIfPossible(batch)) { 34 previous->fBatch->combineIfPossible(batch)) {
34 return NULL; 35 return NULL;
35 } 36 }
36 37
37 if (intersect(previous->fBatch->bounds(), batch->bounds())) { 38 if (intersect(previous->fBatch->bounds(), batch->bounds())) {
38 break; 39 break;
39 } 40 }
41 } else if (Cmd::kClear_CmdType == reverseIter->type()) {
42 Clear* previous = static_cast<Clear*>(reverseIter.get());
43
44 // We set the color to illegal if we are doing a discard.
45 // If we can ignore the rect, then we do a full clear
46 if (previous->fColor == GrColor_ILLEGAL ||
47 previous->fCanIgnoreRect ||
48 intersect(batch->bounds(), previous->fRect)) {
49 break;
50 }
40 } else { 51 } else {
41 // TODO temporary until we can navigate the other types of comma nds 52 // TODO temporary until we can navigate the other types of comma nds
42 break; 53 break;
43 } 54 }
44 } while (reverseIter.previous() && ++i < kMaxLookback); 55 } while (reverseIter.previous() && ++i < kMaxLookback);
45 } 56 }
46 57
47 return GrNEW_APPEND_TO_RECORDER(*this->cmdBuffer(), DrawBatch, (state, batch , 58 return GrNEW_APPEND_TO_RECORDER(*this->cmdBuffer(), DrawBatch, (state, batch ,
48 this->batchT arget())); 59 this->batchT arget()));
49 } 60 }
OLDNEW
« no previous file with comments | « src/gpu/GrCommandBuilder.cpp ('k') | src/gpu/GrTargetCommands.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698