Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 1161603009: fixes #200, library prefixes for unknown imports (Closed)

Created:
5 years, 6 months ago by Jennifer Messerly
Modified:
5 years, 6 months ago
Reviewers:
vsm
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

fixes #200, library prefixes for unknown imports Take 2. The first version passed checker_test but not inferred_type_test. The library prefix staticElement check needs to come first. R=vsm@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/2db85f9a045562bd5952cb25d956f718c59a1938

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M lib/src/utils.dart View 1 chunk +10 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Jennifer Messerly
actually passing presubmit this time :)
5 years, 6 months ago (2015-06-02 20:44:36 UTC) #2
vsm
lgtm
5 years, 6 months ago (2015-06-02 23:51:30 UTC) #3
Jennifer Messerly
5 years, 6 months ago (2015-06-03 00:06:11 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2db85f9a045562bd5952cb25d956f718c59a1938 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698