Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Unified Diff: lib/src/utils.dart

Issue 1161603009: fixes #200, library prefixes for unknown imports (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/src/utils.dart
diff --git a/lib/src/utils.dart b/lib/src/utils.dart
index 4c7339520c673f724b77c967c1d74164a4615bbe..96166b0998e1e7293bde20fc0c3f7e1a34b89aac 100644
--- a/lib/src/utils.dart
+++ b/lib/src/utils.dart
@@ -207,8 +207,16 @@ _MemberTypeGetter _memberTypeGetter(ExecutableElement member) {
return f;
}
-bool isDynamicTarget(Expression node) =>
- node != null && !isLibraryPrefix(node) && node.staticType.isDynamic;
+bool isDynamicTarget(Expression node) {
+ if (node == null) return false;
+
+ if (isLibraryPrefix(node)) return false;
+
+ // Null type happens when we have unknown identifiers, like a dart: import
+ // that doesn't resolve.
+ var type = node.staticType;
+ return type == null || type.isDynamic;
+}
bool isLibraryPrefix(Expression node) =>
node is SimpleIdentifier && node.staticElement is PrefixElement;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698