Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Unified Diff: gpu/command_buffer/service/shader_translator_unittest.cc

Issue 1161463013: Remove ShaderTranslatorTest.BuiltInFunctionEmulation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fixed typo Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gpu/command_buffer/service/shader_translator_unittest.cc
diff --git a/gpu/command_buffer/service/shader_translator_unittest.cc b/gpu/command_buffer/service/shader_translator_unittest.cc
index b9efe24707b1f5c4c9909876f4fcc757e060888f..5f6173818f922b1fccf54e31bf338e68873c5ec4 100644
--- a/gpu/command_buffer/service/shader_translator_unittest.cc
+++ b/gpu/command_buffer/service/shader_translator_unittest.cc
@@ -282,39 +282,6 @@ TEST_F(ShaderTranslatorTest, GetUniforms) {
EXPECT_STREQ("bar[1].foo.color[0]", original_name.c_str());
}
-#if defined(OS_MACOSX)
-TEST_F(ShaderTranslatorTest, BuiltInFunctionEmulation) {
- // This test might become invalid in the future when ANGLE Translator is no
- // longer emulate dot(float, float) in Mac, or the emulated function name is
- // no longer webgl_dot_emu.
- const char* shader =
- "void main() {\n"
- " gl_Position = vec4(dot(1.0, 1.0), 1.0, 1.0, 1.0);\n"
- "}";
-
- std::string info_log, translated_source;
- int shader_version;
- AttributeMap attrib_map;
- UniformMap uniform_map;
- VaryingMap varying_map;
- NameMap name_map;
- EXPECT_TRUE(vertex_translator_->Translate(shader,
- &info_log,
- &translated_source,
- &shader_version,
- &attrib_map,
- &uniform_map,
- &varying_map,
- &name_map));
- // Info log must be NULL.
- EXPECT_TRUE(info_log.empty());
- // Translated shader must be valid and non-empty.
- ASSERT_FALSE(translated_source.empty());
- EXPECT_TRUE(strstr(translated_source.c_str(),
- "webgl_dot_emu") != NULL);
-}
-#endif
-
TEST_F(ShaderTranslatorTest, OptionsString) {
scoped_refptr<ShaderTranslator> translator_1 = new ShaderTranslator();
scoped_refptr<ShaderTranslator> translator_2 = new ShaderTranslator();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698