sync/util/cryptographer.cc - Issue 1161463005: [Sync] Don't crash for encryption errors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sync/util/cryptographer.cc

Issue 1161463005: [Sync] Don't crash for encryption errors (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add comments Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sync/util/cryptographer.cc

diff --git a/sync/util/cryptographer.cc b/sync/util/cryptographer.cc

index c22f0a322e6b0008f3f8aec3d336119aeb96594a..2db6037789b595da9272b9bcb92c4ab9cf181047 100644

--- a/sync/util/cryptographer.cc

+++ b/sync/util/cryptographer.cc

@@ -127,7 +127,7 @@ std::string Cryptographer::DecryptToString(

const sync_pb::EncryptedData& encrypted) const {

NigoriMap::const_iterator it = nigoris_.find(encrypted.key_name());

if (nigoris_.end() == it) {

- NOTREACHED() << "Cannot decrypt message";

+ LOG(ERROR) << "Cannot decrypt message";

stanisc 2015/06/09 00:04:02 Consider adding a comment explaining how this coul

Nicolas Zea 2015/06/09 19:42:03 Done.

return std::string(); // Caller should have called CanDecrypt(encrypt).

}

« sync/internal_api/write_node.cc ('K') | « sync/internal_api/write_node.cc ('k') | no next file » | no next file with comments »