[Sync] Don't crash for encryption errors

sync/internal_api/write_node.cc

Index: sync/internal_api/write_node.cc
diff --git a/sync/internal_api/write_node.cc b/sync/internal_api/write_node.cc
index cefe8547e12108a4200fd466a59312798bf5496a..4f49dfde29b10ad85482ee23f3846de4df4db409 100644
--- a/sync/internal_api/write_node.cc
+++ b/sync/internal_api/write_node.cc
@@ -168,8 +168,8 @@ void WriteNode::SetPasswordSpecifics(
   // This will only update password_specifics if the underlying unencrypted blob
   // was different from |data| or was not encrypted with the proper passphrase.
   if (!cryptographer->Encrypt(data, password_specifics->mutable_encrypted())) {
-    NOTREACHED() << "Failed to encrypt password, possibly due to sync node "
-                 << "corruption";
+    LOG(ERROR) << "Failed to encrypt password, possibly due to sync node "

[stanisc, 2015/06/09 00:04:02]

Should this code also upload the dump to give this failure some visibility?

[Nicolas Zea, 2015/06/09 19:42:03]

The DecryptIfNecessary method's calls to OnUnrecoverableError will trigger an
upload.

+               << "corruption";
     return;
   }
   SetEntitySpecifics(entity_specifics);