Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(576)

Unified Diff: gpu/command_buffer/client/cmd_buffer_helper.h

Issue 11613021: Removing the JumpRelative, Call, CallRelative and Return commands. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | gpu/command_buffer/common/cmd_buffer_common.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gpu/command_buffer/client/cmd_buffer_helper.h
diff --git a/gpu/command_buffer/client/cmd_buffer_helper.h b/gpu/command_buffer/client/cmd_buffer_helper.h
index 8e7cd78caf70eb6f3c943ee28ea9b156d9394227..7e44de9b4d0c16fda6eabdfc7e85b822fb257198 100644
--- a/gpu/command_buffer/client/cmd_buffer_helper.h
+++ b/gpu/command_buffer/client/cmd_buffer_helper.h
@@ -149,41 +149,6 @@ class GPU_EXPORT CommandBufferHelper {
}
}
- void Jump(uint32 offset) {
greggman 2012/12/19 03:32:18 Isn't Jump still needed? You seem to be keeping Ju
dsinclair 2012/12/19 03:41:07 The code that uses Jump in cmd_buffer_helper.cc us
- cmd::Jump* cmd = GetCmdSpace<cmd::Jump>();
- if (cmd) {
- cmd->Init(offset);
- }
- }
-
- void JumpRelative(int32 offset) {
- cmd::JumpRelative* cmd = GetCmdSpace<cmd::JumpRelative>();
- if (cmd) {
- cmd->Init(offset);
- }
- }
-
- void Call(uint32 offset) {
- cmd::Call* cmd = GetCmdSpace<cmd::Call>();
- if (cmd) {
- cmd->Init(offset);
- }
- }
-
- void CallRelative(int32 offset) {
- cmd::CallRelative* cmd = GetCmdSpace<cmd::CallRelative>();
- if (cmd) {
- cmd->Init(offset);
- }
- }
-
- void Return() {
- cmd::Return* cmd = GetCmdSpace<cmd::Return>();
- if (cmd) {
- cmd->Init();
- }
- }
-
void SetBucketSize(uint32 bucket_id, uint32 size) {
cmd::SetBucketSize* cmd = GetCmdSpace<cmd::SetBucketSize>();
if (cmd) {
« no previous file with comments | « no previous file | gpu/command_buffer/common/cmd_buffer_common.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698