Removing the JumpRelative, Call, CallRelative and Return commands.

gpu/command_buffer/client/cmd_buffer_helper.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This file contains the command buffer helper class.
 
 #ifndef GPU_COMMAND_BUFFER_CLIENT_CMD_BUFFER_HELPER_H_
 #define GPU_COMMAND_BUFFER_CLIENT_CMD_BUFFER_HELPER_H_
 
 #include <string.h>
@@ skipping 131 matching lines @@
     }
   }
 
   void SetToken(uint32 token) {
     cmd::SetToken* cmd = GetCmdSpace<cmd::SetToken>();
     if (cmd) {
       cmd->Init(token);
     }
   }
 
-  void Jump(uint32 offset) {

[greggman, 2012/12/19 03:32:18]

Isn't Jump still needed? You seem to be keeping Jump everywhere else.

[dsinclair, 2012/12/19 03:41:07]

The code that uses Jump in cmd_buffer_helper.cc uses cmd::Jump::Set directly. It
doesn't use the Jump method for some reason. I figured taking the method out was
safe (everything is compiling and most of the try-bots are happy), and removes
the client side API if not the struct and service side handling.

-    cmd::Jump* cmd = GetCmdSpace<cmd::Jump>();
-    if (cmd) {
-      cmd->Init(offset);
-    }
-  }
-
-  void JumpRelative(int32 offset) {
-    cmd::JumpRelative* cmd = GetCmdSpace<cmd::JumpRelative>();
-    if (cmd) {
-      cmd->Init(offset);
-    }
-  }
-
-  void Call(uint32 offset) {
-    cmd::Call* cmd = GetCmdSpace<cmd::Call>();
-    if (cmd) {
-      cmd->Init(offset);
-    }
-  }
-
-  void CallRelative(int32 offset) {
-    cmd::CallRelative* cmd = GetCmdSpace<cmd::CallRelative>();
-    if (cmd) {
-      cmd->Init(offset);
-    }
-  }
-
-  void Return() {
-    cmd::Return* cmd = GetCmdSpace<cmd::Return>();
-    if (cmd) {
-      cmd->Init();
-    }
-  }
-
   void SetBucketSize(uint32 bucket_id, uint32 size) {
     cmd::SetBucketSize* cmd = GetCmdSpace<cmd::SetBucketSize>();
     if (cmd) {
       cmd->Init(bucket_id, size);
     }
   }
 
   void SetBucketData(uint32 bucket_id,
                      uint32 offset,
                      uint32 size,
@@ skipping 104 matching lines @@
   // Using C runtime instead of base because this file cannot depend on base.
   clock_t last_flush_time_;
 
   friend class CommandBufferHelperTest;
   DISALLOW_COPY_AND_ASSIGN(CommandBufferHelper);
 };
 
 }  // namespace gpu
 
 #endif  // GPU_COMMAND_BUFFER_CLIENT_CMD_BUFFER_HELPER_H_