Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 11613012: NaCl: Move all browser tests into nacl_irt_test_env (Closed)

Created:
8 years ago by Mark Seaborn
Modified:
7 years, 11 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

NaCl: Move all browser tests into nacl_irt_test_env IRT-using nexes are normally built in nacl_irt_test_env, not nacl_env. All of chrome_browser_tests uses the IRT, so changing these tests to use nacl_irt_test_env brings chrome_browser_tests into line with the rest of the NaCl Scons build. This will let us fix libimc_syscalls to call GC hooks without breaking linking the nexes in chrome_browser_tests (since some tests there use libimc_syscalls). BUG=https://code.google.com/p/nativeclient/issues/detail?id=3253 TEST=nacl_integration + count tests to check we haven't lost any Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=176224

Patch Set 1 #

Patch Set 2 : Needs more changes #

Patch Set 3 : Rerun try #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -16 lines) Patch
M chrome/test/nacl_test_injection/buildbot_chrome_nacl_stage.py View 1 2 1 chunk +2 lines, -4 lines 0 comments Download
M ppapi/native_client/chrome_main.scons View 2 chunks +9 lines, -11 lines 0 comments Download
M ppapi/native_client/tests/nacl_browser/inbrowser_test_runner/nacl.scons View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Mark Seaborn
This depends on rolling https://codereview.chromium.org/11820043 into Chromium.
7 years, 11 months ago (2013-01-10 20:21:12 UTC) #1
Nick Bray (chromium)
7 years, 11 months ago (2013-01-10 22:24:57 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698