Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 1161243005: Revert of [es6] Super call in arrows and eval (Closed)

Created:
5 years, 6 months ago by arv (Not doing code reviews)
Modified:
5 years, 6 months ago
Reviewers:
wingo, adamk
CC:
v8-dev, Michael Hablich, caitp (gmail)
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [es6] Super call in arrows and eval (patchset #5 id:100001 of https://codereview.chromium.org/1146863007/) Reason for revert: Fails http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap%20-%20debug%20-%201/builds/579/steps/Check/logs/super Original issue's description: > [es6] Super call in arrows and eval > > This splits the SuperReference AST node into SuperPropertyReference and > SuperCallReference. The super call reference node consists of three > unresolved vars to this, new.target and this_function. These gets > declared when the right function is entered and if it is in use. The > variables gets assigned in FullCodeGenerator::Generate. > > BUG=v8:3768 > LOG=N > R=wingo@igalia.com, adamk@chromium.org > > Committed: https://crrev.com/673c0516ab96f24343bbb26e0afc2846b5a679df > Cr-Commit-Position: refs/heads/master@{#28731} TBR=wingo@igalia.com,adamk@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:3768 Committed: https://crrev.com/88b1c9170a0293cbcc8bdaf57fbe12744b48d7e8 Cr-Commit-Position: refs/heads/master@{#28735}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+359 lines, -760 lines) Patch
M src/arm/full-codegen-arm.cc View 19 chunks +43 lines, -69 lines 0 comments Download
M src/arm64/full-codegen-arm64.cc View 19 chunks +43 lines, -71 lines 0 comments Download
M src/ast.h View 5 chunks +12 lines, -48 lines 0 comments Download
M src/ast.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ast-numbering.cc View 1 chunk +2 lines, -13 lines 0 comments Download
M src/ast-value-factory.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/ast-graph-builder.cc View 1 chunk +1 line, -9 lines 0 comments Download
M src/compiler/ast-loop-assignment-analyzer.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/full-codegen.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/full-codegen.cc View 3 chunks +2 lines, -19 lines 0 comments Download
M src/hydrogen.cc View 1 chunk +1 line, -10 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 19 chunks +43 lines, -70 lines 0 comments Download
M src/mips/full-codegen-mips.cc View 19 chunks +43 lines, -68 lines 0 comments Download
M src/mips64/full-codegen-mips64.cc View 19 chunks +43 lines, -68 lines 0 comments Download
M src/parser.h View 1 chunk +1 line, -4 lines 0 comments Download
M src/parser.cc View 3 chunks +9 lines, -32 lines 0 comments Download
M src/pattern-rewriter.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/preparser.h View 4 chunks +6 lines, -12 lines 0 comments Download
M src/prettyprinter.cc View 3 chunks +6 lines, -20 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/scopes.h View 2 chunks +0 lines, -9 lines 0 comments Download
M src/scopes.cc View 5 chunks +51 lines, -57 lines 0 comments Download
M src/typing.cc View 1 chunk +1 line, -4 lines 0 comments Download
M src/variables.h View 2 chunks +2 lines, -1 line 0 comments Download
M src/x64/full-codegen-x64.cc View 19 chunks +42 lines, -69 lines 0 comments Download
M test/mjsunit/harmony/super.js View 2 chunks +1 line, -97 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
arv (Not doing code reviews)
Created Revert of [es6] Super call in arrows and eval
5 years, 6 months ago (2015-06-01 16:09:31 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1161243005/1
5 years, 6 months ago (2015-06-01 16:09:49 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-01 16:10:18 UTC) #3
commit-bot: I haz the power
5 years, 6 months ago (2015-06-01 16:10:27 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/88b1c9170a0293cbcc8bdaf57fbe12744b48d7e8
Cr-Commit-Position: refs/heads/master@{#28735}

Powered by Google App Engine
This is Rietveld 408576698