Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(459)

Issue 1146863007: [es6] Super call in arrows and eval (Closed)

Created:
5 years, 6 months ago by arv (Not doing code reviews)
Modified:
5 years, 6 months ago
Reviewers:
wingo, adamk
CC:
v8-dev, Michael Hablich, caitp (gmail)
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[es6] Super call in arrows and eval This splits the SuperReference AST node into SuperPropertyReference and SuperCallReference. The super call reference node consists of three unresolved vars to this, new.target and this_function. These gets declared when the right function is entered and if it is in use. The variables gets assigned in FullCodeGenerator::Generate. BUG=v8:3768 LOG=N R=wingo@igalia.com, adamk@chromium.org Committed: https://crrev.com/673c0516ab96f24343bbb26e0afc2846b5a679df Cr-Commit-Position: refs/heads/master@{#28731}

Patch Set 1 : Cleanup #

Patch Set 2 : all ports done #

Patch Set 3 : git rebase #

Total comments: 3

Patch Set 4 : git rebase #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+743 lines, -342 lines) Patch
M src/arm/full-codegen-arm.cc View 1 2 3 4 19 chunks +67 lines, -41 lines 0 comments Download
M src/arm64/full-codegen-arm64.cc View 1 2 3 4 19 chunks +69 lines, -41 lines 0 comments Download
M src/ast.h View 1 2 5 chunks +47 lines, -11 lines 0 comments Download
M src/ast.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/ast-numbering.cc View 1 2 3 1 chunk +13 lines, -2 lines 0 comments Download
M src/ast-value-factory.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/ast-graph-builder.cc View 1 2 3 1 chunk +9 lines, -1 line 0 comments Download
M src/compiler/ast-loop-assignment-analyzer.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/full-codegen.h View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M src/full-codegen.cc View 1 2 3 3 chunks +19 lines, -2 lines 0 comments Download
M src/hydrogen.cc View 1 2 3 1 chunk +10 lines, -1 line 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 2 3 4 19 chunks +68 lines, -41 lines 0 comments Download
M src/mips/full-codegen-mips.cc View 1 2 3 4 19 chunks +66 lines, -41 lines 0 comments Download
M src/mips64/full-codegen-mips64.cc View 1 2 3 4 19 chunks +66 lines, -41 lines 0 comments Download
M src/parser.h View 1 chunk +4 lines, -1 line 0 comments Download
M src/parser.cc View 3 chunks +32 lines, -9 lines 0 comments Download
M src/pattern-rewriter.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/preparser.h View 4 chunks +12 lines, -6 lines 0 comments Download
M src/prettyprinter.cc View 3 chunks +19 lines, -5 lines 0 comments Download
M src/runtime/runtime.h View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M src/scopes.h View 2 chunks +9 lines, -0 lines 0 comments Download
M src/scopes.cc View 1 5 chunks +54 lines, -48 lines 0 comments Download
M src/typing.cc View 1 chunk +4 lines, -1 line 0 comments Download
M src/variables.h View 2 chunks +1 line, -2 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 1 2 3 4 19 chunks +67 lines, -40 lines 0 comments Download
M test/mjsunit/harmony/super.js View 2 chunks +97 lines, -1 line 0 comments Download

Messages

Total messages: 19 (6 generated)
arv (Not doing code reviews)
Cleanup
5 years, 6 months ago (2015-05-27 19:34:30 UTC) #1
arv (Not doing code reviews)
PTAL Only x64 is done. I'll start the porting soon.
5 years, 6 months ago (2015-05-27 19:36:39 UTC) #4
arv (Not doing code reviews)
all ports done
5 years, 6 months ago (2015-05-27 22:07:11 UTC) #5
arv (Not doing code reviews)
git rebase
5 years, 6 months ago (2015-05-27 22:27:31 UTC) #6
arv (Not doing code reviews)
All ports done
5 years, 6 months ago (2015-05-27 22:28:39 UTC) #7
adamk
Sorry for the tc39-induced delay. lgtm % some CallRuntime argument length issues. Would like wingo ...
5 years, 6 months ago (2015-05-29 19:14:46 UTC) #8
arv (Not doing code reviews)
I'll wait until next week to see if Andy is back (Dmitry is gone for ...
5 years, 6 months ago (2015-05-29 19:17:17 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1146863007/60001
5 years, 6 months ago (2015-06-01 14:00:24 UTC) #11
arv (Not doing code reviews)
git rebase
5 years, 6 months ago (2015-06-01 14:21:59 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1146863007/100001
5 years, 6 months ago (2015-06-01 14:33:41 UTC) #16
commit-bot: I haz the power
Committed patchset #5 (id:100001)
5 years, 6 months ago (2015-06-01 15:02:35 UTC) #17
commit-bot: I haz the power
Patchset 5 (id:??) landed as https://crrev.com/673c0516ab96f24343bbb26e0afc2846b5a679df Cr-Commit-Position: refs/heads/master@{#28731}
5 years, 6 months ago (2015-06-01 15:02:46 UTC) #18
arv (Not doing code reviews)
5 years, 6 months ago (2015-06-01 16:09:31 UTC) #19
Message was sent while issue was closed.
A revert of this CL (patchset #5 id:100001) has been created in
https://codereview.chromium.org/1161243005/ by arv@chromium.org.

The reason for reverting is: Fails 

http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap%20-%20....

Powered by Google App Engine
This is Rietveld 408576698