Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: ios/chrome/browser/translate/translate_message_infobar_controller.mm

Issue 1161243002: Fixit: Cleanup of InfoBarController. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Adding mising forward declaration. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/translate/translate_message_infobar_controller.mm
diff --git a/ios/chrome/browser/translate/translate_message_infobar_controller.mm b/ios/chrome/browser/translate/translate_message_infobar_controller.mm
index 442d9a17df4b7fdef1a4753cb0e54f8bc3dd1239..c0b2c4abedcebefb9e056563011d48bf16747f00 100644
--- a/ios/chrome/browser/translate/translate_message_infobar_controller.mm
+++ b/ios/chrome/browser/translate/translate_message_infobar_controller.mm
@@ -21,38 +21,35 @@
@implementation TranslateMessageInfoBarController
-#pragma mark -
-#pragma mark InfoBarControllerProtocol
-
-- (void)layoutForDelegate:(infobars::InfoBarDelegate*)delegate
- frame:(CGRect)frame {
+- (base::scoped_nsobject<UIView<InfoBarViewProtocol>>)
+ viewForDelegate:(infobars::InfoBarDelegate*)delegate
+ frame:(CGRect)frame {
+ base::scoped_nsobject<UIView<InfoBarViewProtocol>> infoBarView;
translate::TranslateInfoBarDelegate* translateInfoBarDelegate =
delegate->AsTranslateInfoBarDelegate();
- DCHECK(!infoBarView_);
- infoBarView_.reset([ios::GetChromeBrowserProvider()->CreateInfoBarView()
- initWithFrame:frame
- delegate:delegate_]);
+ infoBarView.reset(
+ ios::GetChromeBrowserProvider()->CreateInfoBarView(frame, self.delegate));
// Icon
gfx::Image icon = translateInfoBarDelegate->GetIcon();
if (!icon.IsEmpty())
- [infoBarView_ addLeftIcon:icon.ToUIImage()];
+ [infoBarView addLeftIcon:icon.ToUIImage()];
// Text.
- [infoBarView_
- addLabel:base::SysUTF16ToNSString(
- translateInfoBarDelegate->GetMessageInfoBarText())];
+ [infoBarView addLabel:base::SysUTF16ToNSString(
+ translateInfoBarDelegate->GetMessageInfoBarText())];
// Close button.
- [infoBarView_ addCloseButtonWithTag:TranslateInfoBarIOSTag::CLOSE
- target:self
- action:@selector(infoBarButtonDidPress:)];
+ [infoBarView addCloseButtonWithTag:TranslateInfoBarIOSTag::CLOSE
+ target:self
+ action:@selector(infoBarButtonDidPress:)];
// Other button.
base::string16 buttonText(
translateInfoBarDelegate->GetMessageInfoBarButtonText());
if (!buttonText.empty()) {
- [infoBarView_ addButton:base::SysUTF16ToNSString(buttonText)
- tag:TranslateInfoBarIOSTag::MESSAGE
- target:self
- action:@selector(infoBarButtonDidPress:)];
+ [infoBarView addButton:base::SysUTF16ToNSString(buttonText)
+ tag:TranslateInfoBarIOSTag::MESSAGE
+ target:self
+ action:@selector(infoBarButtonDidPress:)];
}
+ return infoBarView;
}
#pragma mark - Handling of User Events
@@ -61,16 +58,16 @@
// This press might have occurred after the user has already pressed a button,
// in which case the view has been detached from the delegate and this press
// should be ignored.
- if (!delegate_) {
+ if (!self.delegate) {
return;
}
if ([sender isKindOfClass:[UIButton class]]) {
NSUInteger buttonId = static_cast<UIButton*>(sender).tag;
if (buttonId == TranslateInfoBarIOSTag::CLOSE) {
- delegate_->InfoBarDidCancel();
+ self.delegate->InfoBarDidCancel();
} else {
DCHECK(buttonId == TranslateInfoBarIOSTag::MESSAGE);
- delegate_->InfoBarButtonDidPress(buttonId);
+ self.delegate->InfoBarButtonDidPress(buttonId);
}
}
}

Powered by Google App Engine
This is Rietveld 408576698