Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Unified Diff: ios/public/provider/chrome/browser/chrome_browser_provider.h

Issue 1161243002: Fixit: Cleanup of InfoBarController. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Adding mising forward declaration. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/public/provider/chrome/browser/chrome_browser_provider.h
diff --git a/ios/public/provider/chrome/browser/chrome_browser_provider.h b/ios/public/provider/chrome/browser/chrome_browser_provider.h
index 668c6223beb1145e1e9c1b9dcc9266857adbef66..2cfe3b2115ca667bdb6c6ba02e2587706c978dee 100644
--- a/ios/public/provider/chrome/browser/chrome_browser_provider.h
+++ b/ios/public/provider/chrome/browser/chrome_browser_provider.h
@@ -5,6 +5,9 @@
#ifndef IOS_PUBLIC_PROVIDER_CHROME_BROWSER_CHROME_BROWSER_PROVIDER_H_
#define IOS_PUBLIC_PROVIDER_CHROME_BROWSER_CHROME_BROWSER_PROVIDER_H_
+#include <CoreGraphics/CoreGraphics.h>
+
+class InfoBarViewDelegate;
class PrefService;
namespace net {
@@ -20,9 +23,10 @@ class WebState;
#ifdef __OBJC__
@class UIView;
@protocol InfoBarViewProtocol;
-typedef UIView<InfoBarViewProtocol> InfoBarViewPlaceholder;
+typedef UIView<InfoBarViewProtocol>* InfoBarViewPlaceholder;
#else
-class InfoBarViewPlaceholder;
+class InfoBarViewPlaceholderClass;
+typedef InfoBarViewPlaceholderClass* InfoBarViewPlaceholder;
class UIView;
#endif
@@ -51,9 +55,11 @@ class ChromeBrowserProvider {
virtual PrefService* GetLocalState();
// Returns an UpdatableResourceProvider instance.
virtual UpdatableResourceProvider* GetUpdatableResourceProvider();
- // Returns an instance of an infobar view. The caller is responsible for
- // initializing the returned object and releasing it when appropriate.
- virtual InfoBarViewPlaceholder* CreateInfoBarView();
+ // Returns an infobar view conforming to the InfoBarViewProtocol. The returned
+ // object is retained.
+ virtual InfoBarViewPlaceholder CreateInfoBarView(
+ CGRect frame,
+ InfoBarViewDelegate* delegate);
// Returns an instance of a string provider.
virtual StringProvider* GetStringProvider();
virtual GeolocationUpdaterProvider* GetGeolocationUpdaterProvider();

Powered by Google App Engine
This is Rietveld 408576698