Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 1161243002: Fixit: Cleanup of InfoBarController. (Closed)

Created:
5 years, 6 months ago by noyau (Ping after 24h)
Modified:
5 years, 6 months ago
Reviewers:
droger
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixit: Cleanup of InfoBarController. Removed instance variables from the header file, and cleaned up subclasses initializing ivars directly. Changed the way the InfobarView is created to avoid passing around an allocated but uninitialized object. BUG=None Committed: https://crrev.com/00a31e2fd4e7f4ae5880a7396d95ca6071f974c7 Cr-Commit-Position: refs/heads/master@{#332181}

Patch Set 1 #

Patch Set 2 : Returns a retained view instead of the class. #

Patch Set 3 : Adding mising forward declaration. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+175 lines, -152 lines) Patch
M ios/chrome/browser/infobars/confirm_infobar_controller.mm View 1 3 chunks +24 lines, -24 lines 0 comments Download
M ios/chrome/browser/infobars/infobar.h View 1 chunk +6 lines, -2 lines 0 comments Download
M ios/chrome/browser/infobars/infobar.mm View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/infobars/infobar_controller.h View 2 chunks +16 lines, -13 lines 0 comments Download
M ios/chrome/browser/infobars/infobar_controller.mm View 1 chunk +25 lines, -12 lines 0 comments Download
M ios/chrome/browser/translate/after_translate_infobar_controller.mm View 1 3 chunks +22 lines, -21 lines 0 comments Download
M ios/chrome/browser/translate/before_translate_infobar_controller.mm View 1 4 chunks +23 lines, -24 lines 0 comments Download
M ios/chrome/browser/translate/never_translate_infobar_controller.mm View 1 2 chunks +24 lines, -23 lines 0 comments Download
M ios/chrome/browser/translate/translate_message_infobar_controller.mm View 1 2 chunks +20 lines, -23 lines 0 comments Download
M ios/public/provider/chrome/browser/chrome_browser_provider.h View 1 2 3 chunks +11 lines, -5 lines 0 comments Download
M ios/public/provider/chrome/browser/chrome_browser_provider.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
M ios/public/provider/chrome/browser/ui/infobar_view_protocol.h View 1 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
noyau (Ping after 24h)
As discussed offline, the provider now returns a retained object.
5 years, 6 months ago (2015-06-01 11:52:14 UTC) #2
droger
lgtm
5 years, 6 months ago (2015-06-01 11:55:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1161243002/20001
5 years, 6 months ago (2015-06-01 12:00:40 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/29987)
5 years, 6 months ago (2015-06-01 12:07:53 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1161243002/40001
5 years, 6 months ago (2015-06-01 12:15:32 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 6 months ago (2015-06-01 12:23:06 UTC) #11
commit-bot: I haz the power
5 years, 6 months ago (2015-06-01 12:24:04 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/00a31e2fd4e7f4ae5880a7396d95ca6071f974c7
Cr-Commit-Position: refs/heads/master@{#332181}

Powered by Google App Engine
This is Rietveld 408576698