chrome/browser/android/banners/app_banner_data_fetcher_android.h - Issue 1161233005: Implement app banner info bars on desktop.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/banners/app_banner_data_fetcher_android.h

Issue 1161233005: Implement app banner info bars on desktop. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@stop-icon-overgeneration

Patch Set: Formatting and code cleanliness Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/app/theme/theme_resources.grd ('k') | chrome/browser/android/banners/app_banner_data_fetcher_android.cc » ('j') | chrome/browser/banners/app_banner_data_fetcher.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/banners/app_banner_data_fetcher_android.h

diff --git a/chrome/browser/android/banners/app_banner_data_fetcher_android.h b/chrome/browser/android/banners/app_banner_data_fetcher_android.h

index 7114301e0122160a1efe9b039301ef9e52a9b442..e059522e634851aaf6bd37b46f20af92c478e5cf 100644

--- a/chrome/browser/android/banners/app_banner_data_fetcher_android.h

+++ b/chrome/browser/android/banners/app_banner_data_fetcher_android.h

@@ -31,8 +31,8 @@ class AppBannerDataFetcherAndroid : public AppBannerDataFetcher {

std::string GetBannerType() override;

std::string GetAppIdentifier() override;

- infobars::InfoBar* CreateBanner(const SkBitmap* icon,

- const base::string16& title) override;

+ void ShowBanner(const SkBitmap* icon,

+ const base::string16& title) override;

private:

base::android::ScopedJavaGlobalRef<jobject> native_app_data_;