chrome/browser/banners/app_banner_settings_helper.h - Issue 1161233005: Implement app banner info bars on desktop.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/banners/app_banner_settings_helper.h

Issue 1161233005: Implement app banner info bars on desktop. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@stop-icon-overgeneration

Patch Set: Fixing display bug on Android Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/banners/app_banner_manager.cc ('K') | « chrome/browser/banners/app_banner_manager.cc ('k') | chrome/browser/banners/app_banner_settings_helper.cc » ('j') | chrome/browser/banners/app_banner_settings_helper.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/banners/app_banner_settings_helper.h

diff --git a/chrome/browser/banners/app_banner_settings_helper.h b/chrome/browser/banners/app_banner_settings_helper.h

index 8e0e971589ad75acc3160e7f25492d1eaf555671..8b5caf185993769bb4c1600530f82236cf9a29e2 100644

--- a/chrome/browser/banners/app_banner_settings_helper.h

+++ b/chrome/browser/banners/app_banner_settings_helper.h

@@ -53,6 +53,18 @@ class AppBannerSettingsHelper {

static void ClearHistoryForURLs(Profile* profile,

const std::set<GURL>& origin_urls);

+ static void RecordBannerWebInstallEvent(

+ content::WebContents* web_contents,

+ const std::string& package_name_or_start_url,

+ const std::string& rappor_metric,

+ int event_request_id_);

+ static void RecordBannerDismissEvent(

+ content::WebContents* web_contents,

+ const std::string& package_name_or_start_url,

+ const std::string& rappor_metric,

+ int event_request_id_);

static void RecordBannerEvent(content::WebContents* web_contents,

const GURL& origin_url,

const std::string& package_name_or_start_url,