Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(428)

Unified Diff: chrome/browser/banners/app_banner_manager.h

Issue 1161233005: Implement app banner info bars on desktop. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@stop-icon-overgeneration
Patch Set: Fixing display bug on Android Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/banners/app_banner_manager.h
diff --git a/chrome/browser/banners/app_banner_manager.h b/chrome/browser/banners/app_banner_manager.h
index a84be6053512a13a9e486103c99699e249c6a007..190308da83a3312e6ee781ea86edbb5ca368ef48 100644
--- a/chrome/browser/banners/app_banner_manager.h
+++ b/chrome/browser/banners/app_banner_manager.h
@@ -10,6 +10,7 @@
#include "base/memory/weak_ptr.h"
#include "chrome/browser/banners/app_banner_data_fetcher.h"
#include "content/public/browser/web_contents_observer.h"
+#include "content/public/browser/web_contents_user_data.h"
#include "third_party/WebKit/public/platform/modules/app_banner/WebAppBannerPromptReply.h"
namespace content {
@@ -28,7 +29,8 @@ class AppBannerDataFetcher;
* requested app. Any work in progress for other apps is discarded.
*/
class AppBannerManager : public content::WebContentsObserver,
- public AppBannerDataFetcher::Delegate {
+ public AppBannerDataFetcher::Delegate,
+ public content::WebContentsUserData<AppBannerManager> {
public:
static bool IsEnabled();
static void DisableSecureSchemeCheckForTesting();
@@ -58,6 +60,9 @@ class AppBannerManager : public content::WebContentsObserver,
int ideal_icon_size() { return ideal_icon_size_; }
private:
+ explicit AppBannerManager(content::WebContents* web_contents);
+ friend class content::WebContentsUserData<AppBannerManager>;
+
// AppBannerDataFetcher::Delegate overrides.
bool HandleNonWebApp(const std::string& platform,
const GURL& url,

Powered by Google App Engine
This is Rietveld 408576698