Implement app banner info bars on desktop.

chrome/browser/banners/app_banner_data_fetcher.h

Index: chrome/browser/banners/app_banner_data_fetcher.h
diff --git a/chrome/browser/banners/app_banner_data_fetcher.h b/chrome/browser/banners/app_banner_data_fetcher.h
index fcab9129fac10eb3982b06782f49202b960a4c9e..f82e062782744549ce86b321715a7769a0d06f88 100644
--- a/chrome/browser/banners/app_banner_data_fetcher.h
+++ b/chrome/browser/banners/app_banner_data_fetcher.h
@@ -11,6 +11,7 @@
 #include "base/observer_list.h"
 #include "base/time/time.h"
 #include "chrome/browser/bitmap_fetcher/bitmap_fetcher_delegate.h"
+#include "chrome/common/web_application_info.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/browser/web_contents_observer.h"
 #include "content/public/common/manifest.h"
@@ -20,6 +21,11 @@ namespace chrome {
 class BitmapFetcher;
 }  // namespace chrome
 
+namespace extensions {
+class BookmarkAppHelper;
+class Extension;
+}  // namespace extensions

[benwells, 2015/06/02 05:53:35]

The generic fetcher class is now polluted with desktop only stuff. Can we have a
app_banner_data_fetcher_desktop instead?

[dominickn (DO NOT USE), 2015/06/02 06:51:32]

This also means either adding an AppBannerManagerDesktop, or making the existing
AppBannerManager create an AppBannerDataFetcherDesktop instead of the currently
AppBannerDataFetcher.

I didn't add an explicit desktop version because I conceptualised the Android
one as overriding the desktop implementation, rather than both inheriting from a
single source. I felt like the number of desktop-specific pollutions in the
fetcher class was limited enough to not justify an additional couple of classes.
Thoughts?

+
 namespace infobars {
 class InfoBar;
 }  // namespace infobars
@@ -90,6 +96,10 @@ class AppBannerDataFetcher
   bool OnMessageReceived(const IPC::Message& message,
                          content::RenderFrameHost* render_frame_host) override;
 
+  // Callback for finishing bookmark app creation
+  void FinishCreateBookmarkApp(const extensions::Extension* extension,
+                               const WebApplicationInfo& web_app_info);
+
  protected:
   ~AppBannerDataFetcher() override;
 
@@ -122,6 +132,10 @@ class AppBannerDataFetcher
   // metric being recorded.
   void RecordDidShowBanner(const std::string& event_name);
 
+#if !defined(OS_ANDROID)
+  scoped_ptr<extensions::BookmarkAppHelper> bookmark_app_helper_;
+#endif
+
  private:
   // Callbacks for data retrieval.
   void OnDidGetManifest(const content::Manifest& manifest);