Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Unified Diff: chrome/browser/android/banners/app_banner_data_fetcher_android.cc

Issue 1161233005: Implement app banner info bars on desktop. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@stop-icon-overgeneration
Patch Set: Fixing display bug on Android Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/banners/app_banner_data_fetcher_android.cc
diff --git a/chrome/browser/android/banners/app_banner_data_fetcher_android.cc b/chrome/browser/android/banners/app_banner_data_fetcher_android.cc
index 29934f4639ed049f4990b7adc31df8e8b992cf03..3fcca442378621a34bbfb4ebda05a8b723842b04 100644
--- a/chrome/browser/android/banners/app_banner_data_fetcher_android.cc
+++ b/chrome/browser/android/banners/app_banner_data_fetcher_android.cc
@@ -5,6 +5,7 @@
#include "chrome/browser/android/banners/app_banner_data_fetcher_android.h"
#include "chrome/browser/android/banners/app_banner_infobar_delegate_android.h"
+#include "chrome/browser/infobars/infobar_service.h"
#include "chrome/browser/ui/android/infobars/app_banner_infobar_android.h"
#include "third_party/skia/include/core/SkBitmap.h"
@@ -66,6 +67,8 @@ infobars::InfoBar* AppBannerDataFetcherAndroid::CreateBanner(
if (infobar)
RecordDidShowBanner("AppBanner.NativeApp.Shown");
}
+ InfoBarService::FromWebContents(web_contents)
+ ->AddInfoBar(make_scoped_ptr(infobar));
return infobar;
benwells 2015/06/02 05:53:35 Is there any reason to return infobar now? It feel
dominickn (DO NOT USE) 2015/06/02 06:51:32 Done.
}

Powered by Google App Engine
This is Rietveld 408576698