Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Unified Diff: chrome/browser/banners/app_banner_manager_desktop.cc

Issue 1161233005: Implement app banner info bars on desktop. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@stop-icon-overgeneration
Patch Set: Reuploading Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/banners/app_banner_manager_desktop.cc
diff --git a/chrome/browser/banners/app_banner_manager_desktop.cc b/chrome/browser/banners/app_banner_manager_desktop.cc
new file mode 100644
index 0000000000000000000000000000000000000000..3bf94332dd272922d3c585ed556a60390b773c77
--- /dev/null
+++ b/chrome/browser/banners/app_banner_manager_desktop.cc
@@ -0,0 +1,32 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/banners/app_banner_manager_desktop.h"
+
+#include "chrome/browser/banners/app_banner_data_fetcher_desktop.h"
+#include "extensions/common/constants.h"
+
+namespace {
+// TODO(dominickn) Enforce the set of icons which will guarantee the best
+// user experience.
+int kMinimumIconSize = extension_misc::EXTENSION_ICON_LARGE;
+} // anonymous namespace
+
+DEFINE_WEB_CONTENTS_USER_DATA_KEY(banners::AppBannerManagerDesktop);
+
+namespace banners {
+
+AppBannerManagerDesktop::AppBannerManagerDesktop(
benwells 2015/06/03 06:13:55 Nit: keep functions here in same order as in .h
dominickn (DO NOT USE) 2015/06/03 07:10:36 Done.
+ content::WebContents* web_contents)
+ : AppBannerManager(web_contents, kMinimumIconSize) {
+}
+
+AppBannerDataFetcher* AppBannerManagerDesktop::CreateAppBannerDataFetcher(
+ base::WeakPtr<AppBannerDataFetcher::Delegate> weak_delegate,
+ const int ideal_icon_size) {
+ return new AppBannerDataFetcherDesktop(web_contents(), weak_delegate,
+ ideal_icon_size);
+}
+
+} // namespace banners

Powered by Google App Engine
This is Rietveld 408576698