Convert the WebRtcTestBase to use infobar and bubble autoresponders

Convert the WebRtcTestBase to use infobar and bubble autoresponders

To prevent MediaStreamPermissionTest* flakiness:
(1) Instead of relying on the old infobar notification system, switch to
    the new infobar responder. (As per crbug.com/354380, observers are now
    preferred to notifications.)
(2) Instead of relying on mock permission bubbles, switch to the new
    PermissionBubbleManager responder.
(3) Remove the polling and timeouts.

To satisfy the requirements of the media test cases, I also updated the
InfoBarResponder. It now can handle infobar replacement and dismissing an
infobar without making a choice.

BUG=295723
R=tommi@chromium.org

Committed: https://crrev.com/ccc25707b9788597c55fb4eaa90109500e1f92cb
Cr-Commit-Position: refs/heads/master@{#333360}

Committed: https://crrev.com/f3b3efabfeba898056654426b437c6e9cdb52720
Cr-Commit-Position: refs/heads/master@{#333685}

[felt, 2015-06-08 17:32:45]

Patchset #2 (id:20001) has been deleted

[felt, 2015-06-08 20:46:53]

Patchset #1 (id:1) has been deleted

[felt, 2015-06-08 20:47:07]

Patchset #1 (id:1) has been deleted

[felt, 2015-06-08 20:47:16]

Patchset #1 (id:40001) has been deleted

[felt, 2015-06-08 20:47:24]

Patchset #1 (id:60001) has been deleted

[felt, 2015-06-08 20:47:30]

Patchset #1 (id:80001) has been deleted

[felt, 2015-06-08 20:58:05]

hi tommi, i believe this should fix the flakiness of MediaStreamPermissionTest.
PTAL.

[phoglund_chromium, 2015-06-08 21:14:56]

phoglund@chromium.org changed reviewers:
+ phoglund@chromium.org

[phoglund_chromium, 2015-06-08 21:14:57]

lgtm

Nice, thanks for doing this. I added myself as reviewer since tommi is quite
busy, and I can review all WebRTC browser test changes.

https://codereview.chromium.org/1161153003/diff/120001/chrome/browser/media/w...
File chrome/browser/media/webrtc_browsertest_base.cc (right):

https://codereview.chromium.org/1161153003/diff/120001/chrome/browser/media/w...
chrome/browser/media/webrtc_browsertest_base.cc:115:
->set_auto_response_for_test(PermissionBubbleManager::ACCEPT_ALL);
Nice! We used to have to poll here because the test needed to get control back
to close the infobar, but this is a neat way to sidestep that problem.

[felt, 2015-06-08 21:19:13]

On 2015/06/08 21:14:57, phoglund wrote:
> lgtm
> 
> Nice, thanks for doing this. I added myself as reviewer since tommi is quite
> busy, and I can review all WebRTC browser test changes.

thanks patrik! however: it looks like you can't give an l-g-t-m for
chrome_media_stream_infobar_browsertest.cc because it doesn't match the regex:
per-file *webrtc*browsertest*=phoglund@chromium.org

maybe you need to update the OWNERS file?

> 
>
https://codereview.chromium.org/1161153003/diff/120001/chrome/browser/media/w...
> File chrome/browser/media/webrtc_browsertest_base.cc (right):
> 
>
https://codereview.chromium.org/1161153003/diff/120001/chrome/browser/media/w...
> chrome/browser/media/webrtc_browsertest_base.cc:115:
> ->set_auto_response_for_test(PermissionBubbleManager::ACCEPT_ALL);
> Nice! We used to have to poll here because the test needed to get control back
> to close the infobar, but this is a neat way to sidestep that problem.

[tommi (sloooow) - chröme, 2015-06-08 21:20:25]

The CQ bit was checked by tommi@chromium.org

[tommi (sloooow) - chröme, 2015-06-08 21:20:26]

lgtm

[felt, 2015-06-08 21:21:11]

felt@chromium.org changed reviewers:
+ peter@chromium.org, pkasting@chromium.org

[commit-bot: I haz the power, 2015-06-08 21:21:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1161153003/120001

[phoglund_chromium, 2015-06-08 21:23:06]

> thanks patrik! however: it looks like you can't give an l-g-t-m for
> chrome_media_stream_infobar_browsertest.cc because it doesn't match the regex:
> per-file mailto:*webrtc*browsertest*=phoglund@chromium.org
> 
> maybe you need to update the OWNERS file?
> 

Aha. Yes, I should, because I wrote the test back in the day :) Well it worked
itself out anyway.

[felt, 2015-06-08 21:23:24]

pkasting:
Please review chrome/browser/infobars/? I had to update the InfoBarResponder to
handle infobar replacement and dismissing infobars.

peter:
Please review chrome/browser/notifications/ and chrome/browser/push_messaging/?
When I updated an InfoBarResponder method signature, I had to also update its
call sites. It should not functionally affect the tests.

[felt, 2015-06-08 21:23:59]

The CQ bit was unchecked by felt@chromium.org

[Peter Kasting, 2015-06-08 21:44:48]

LGTM

[Peter Beverloo, 2015-06-08 21:51:35]

lgtm

[felt, 2015-06-08 22:03:50]

The CQ bit was checked by felt@chromium.org

[commit-bot: I haz the power, 2015-06-08 22:07:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1161153003/120001

[commit-bot: I haz the power, 2015-06-08 22:14:44]

Committed patchset #2 (id:120001)

[commit-bot: I haz the power, 2015-06-08 22:15:35]

Patchset 2 (id:??) landed as
https://crrev.com/ccc25707b9788597c55fb4eaa90109500e1f92cb
Cr-Commit-Position: refs/heads/master@{#333360}

[kjellander (google.com), 2015-06-09 07:48:51]

A revert of this CL (patchset #2 id:120001) has been created in
https://codereview.chromium.org/1175443002/ by kjellander@google.com.

The reason for reverting is: This breaks our AppRTC test at
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/med...

Failing build:
https://build.chromium.org/p/chromium.webrtc/builders/Linux%20Tester/builds/3108

Please re-land this CL after verifying the following passes:
browser_tests --gtest_filter=WebRtcApprtcBrowserTest.*WorksOnApprtc --run-manual

Sorry about that we can't run these tests on trybots..

[felt, 2015-06-10 00:35:57]

Patchset #3 (id:140001) has been deleted

[felt, 2015-06-10 01:41:09]

phoglund: PTAL at chrome/browser/media/chrome_webrtc_apprtc_browsertest.cc. I
updated the tests to use both infobars and permissions. I've made the tests work
simultaneously with either bubbles or infobars, whichever happens to be enabled.

[phoglund_chromium, 2015-06-10 02:05:47]

lgtm

[felt, 2015-06-10 04:37:46]

The CQ bit was checked by felt@chromium.org

[felt, 2015-06-10 04:37:46]

The patchset sent to the CQ was uploaded after l-g-t-m from peter@chromium.org,
tommi@chromium.org, pkasting@chromium.org
Link to the patchset: https://codereview.chromium.org/1161153003/#ps160001
(title: "Fix MANUAL test")

[commit-bot: I haz the power, 2015-06-10 04:37:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1161153003/160001

[commit-bot: I haz the power, 2015-06-10 05:06:39]

Committed patchset #3 (id:160001)

[commit-bot: I haz the power, 2015-06-10 05:07:39]

Patchset 3 (id:??) landed as
https://crrev.com/f3b3efabfeba898056654426b437c6e9cdb52720
Cr-Commit-Position: refs/heads/master@{#333685}