Issue 1161033005: move erase into SkPixmap

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1161033005: move erase into SkPixmap (Closed)

Created:
5 years, 6 months ago by reed1

Modified:
5 years, 6 months ago

Reviewers:

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

More Reviews

Description

move erase into SkPixmap harvested from https://codereview.chromium.org/1148793007 BUG=skia: TBR= Committed: https://skia.googlesource.com/skia/+/0963f5dab079627c5523ce6a443af27a33e361f7

Patch Set 1 #

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+154 lines, -126 lines)			Patch
M	include/core/SkBitmap.h	View	4 chunks	+10 lines, -10 lines	0 comments	Download
M	include/core/SkPixmap.h	View	2 chunks	+34 lines, -0 lines	0 comments	Download
M	src/core/SkBitmap.cpp	View	2 chunks	+4 lines, -108 lines	0 comments	Download
M	src/core/SkPixmap.cpp	View	2 chunks	+106 lines, -8 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1161033005/1

5 years, 6 months ago (2015-06-08 16:11:22 UTC) #2

commit-bot: I haz the power

Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/0963f5dab079627c5523ce6a443af27a33e361f7

5 years, 6 months ago (2015-06-08 16:16:58 UTC) #3

djsollen

5 years, 6 months ago (2015-06-08 17:03:25 UTC) #4

Message was sent while issue was closed.

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1157303008/ by djsollen@google.com.

The reason for reverting is: broken builds.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages