Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1161003002: Split layout2.dart into several files (Closed)

Created:
5 years, 6 months ago by abarth-chromium
Modified:
5 years, 6 months ago
Reviewers:
Hixie
CC:
gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Split layout2.dart into several files Previously layout2.dart was a thousand lines long. R=ianh@google.com Committed: https://chromium.googlesource.com/external/mojo/+/e1212d29040bf02b96612edfe1db3ebf26acd520

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1040 lines, -1610 lines) Patch
M sky/examples/raw/render_paragraph.dart View 2 chunks +5 lines, -2 lines 0 comments Download
D sky/examples/raw/sector-layout.dart View 1 chunk +0 lines, -507 lines 0 comments Download
A + sky/examples/raw/sector_layout.dart View 1 chunk +2 lines, -1 line 0 comments Download
D sky/examples/raw/simple_render_tree.dart View 1 chunk +0 lines, -87 lines 0 comments Download
M sky/examples/raw/touch_demo.dart View 1 chunk +2 lines, -1 line 0 comments Download
M sky/examples/stocks2/lib/stock_app.dart View 1 chunk +0 lines, -1 line 0 comments Download
M sky/examples/stocks2/lib/stock_arrow.dart View 1 chunk +0 lines, -1 line 0 comments Download
M sky/examples/stocks2/lib/stock_menu.dart View 1 chunk +0 lines, -1 line 0 comments Download
M sky/examples/stocks2/lib/stock_row.dart View 1 chunk +0 lines, -1 line 0 comments Download
M sky/sdk/BUILD.gn View 1 chunk +5 lines, -1 line 0 comments Download
M sky/sdk/lib/framework/app.dart View 1 chunk +2 lines, -1 line 0 comments Download
M sky/sdk/lib/framework/components2/checkbox.dart View 1 chunk +0 lines, -1 line 0 comments Download
M sky/sdk/lib/framework/components2/drawer_header.dart View 1 chunk +0 lines, -1 line 0 comments Download
M sky/sdk/lib/framework/components2/ink_splash.dart View 1 chunk +0 lines, -1 line 0 comments Download
M sky/sdk/lib/framework/components2/ink_well.dart View 1 chunk +0 lines, -1 line 0 comments Download
M sky/sdk/lib/framework/components2/input.dart View 1 chunk +0 lines, -1 line 0 comments Download
M sky/sdk/lib/framework/components2/menu_item.dart View 1 chunk +0 lines, -1 line 0 comments Download
M sky/sdk/lib/framework/components2/scaffold.dart View 1 chunk +0 lines, -1 line 0 comments Download
M sky/sdk/lib/framework/components2/tool_bar.dart View 1 chunk +0 lines, -1 line 0 comments Download
M sky/sdk/lib/framework/fn2.dart View 1 chunk +5 lines, -1 line 0 comments Download
D sky/sdk/lib/framework/layout2.dart View 1 chunk +0 lines, -993 lines 0 comments Download
A sky/sdk/lib/framework/rendering/render_block.dart View 1 chunk +69 lines, -0 lines 0 comments Download
A sky/sdk/lib/framework/rendering/render_box.dart View 1 chunk +369 lines, -0 lines 0 comments Download
A sky/sdk/lib/framework/rendering/render_flex.dart View 1 chunk +121 lines, -0 lines 0 comments Download
A sky/sdk/lib/framework/rendering/render_node.dart View 1 chunk +390 lines, -0 lines 0 comments Download
A sky/sdk/lib/framework/rendering/render_paragraph.dart View 1 chunk +64 lines, -0 lines 0 comments Download
M sky/tests/raw/render_box.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/tests/raw/render_flex.dart View 2 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
abarth-chromium
5 years, 6 months ago (2015-05-28 23:36:48 UTC) #1
Hixie
lgtm
5 years, 6 months ago (2015-05-28 23:40:06 UTC) #2
abarth-chromium
5 years, 6 months ago (2015-05-28 23:42:09 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
e1212d29040bf02b96612edfe1db3ebf26acd520 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698