Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5394)

Unified Diff: chromecast/media/cdm/browser_cdm_cast.cc

Issue 1160983002: Allows support for persistent session types in BrowserCdm. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: removes session_type TODO Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromecast/media/cdm/browser_cdm_cast.cc
diff --git a/chromecast/media/cdm/browser_cdm_cast.cc b/chromecast/media/cdm/browser_cdm_cast.cc
index d00a96f25ec8630241ab6d3a29ef95131772642e..9f56a9d61576f917e3208960586aeb10bb1330a1 100644
--- a/chromecast/media/cdm/browser_cdm_cast.cc
+++ b/chromecast/media/cdm/browser_cdm_cast.cc
@@ -54,16 +54,6 @@ void BrowserCdmCast::UnregisterPlayer(int registration_id) {
player_tracker_impl_->UnregisterPlayer(registration_id);
}
ddorwin 2015/05/28 23:51:50 Why are you deleting LoadSession()? This won't com
gunsch 2015/05/28 23:59:12 We have internal implementations that subclass Bro
ddorwin 2015/05/29 02:13:59 Oh, I thought it was possible to build Cast, albei
gunsch 2015/05/29 16:40:10 It is. We don't instantiate any BrowserCdmCast ins
-void BrowserCdmCast::LoadSession(
- ::media::MediaKeys::SessionType session_type,
- const std::string& session_id,
- scoped_ptr<::media::NewSessionCdmPromise> promise) {
- NOTREACHED() << "LoadSession not supported";
- legacy_session_error_cb_.Run(
- session_id, ::media::MediaKeys::Exception::NOT_SUPPORTED_ERROR, 0,
- std::string());
-}
-
::media::CdmContext* BrowserCdmCast::GetCdmContext() {
NOTREACHED();
return nullptr;

Powered by Google App Engine
This is Rietveld 408576698