Allows support for persistent session types in BrowserCdm.

chromecast/media/cdm/browser_cdm_cast.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chromecast/media/cdm/browser_cdm_cast.h"
 
 #include "base/bind.h"
 #include "base/location.h"
 #include "base/single_thread_task_runner.h"
 #include "media/base/cdm_key_information.h"
@@ skipping 35 matching lines @@
 int BrowserCdmCast::RegisterPlayer(const base::Closure& new_key_cb,
                                    const base::Closure& cdm_unset_cb) {
   DCHECK(thread_checker_.CalledOnValidThread());
   return player_tracker_impl_->RegisterPlayer(new_key_cb, cdm_unset_cb);
 }
 
 void BrowserCdmCast::UnregisterPlayer(int registration_id) {
   DCHECK(thread_checker_.CalledOnValidThread());
   player_tracker_impl_->UnregisterPlayer(registration_id);
 }
 

[ddorwin, 2015/05/28 23:51:50]

Why are you deleting LoadSession()? This won't compile will it? (There is no
definition of the MediaKeys interface.)

[gunsch, 2015/05/28 23:59:12]

We have internal implementations that subclass BrowserCdmCast. BrowserCdmCast
also contains its own pure virtual methods.

[ddorwin, 2015/05/29 02:13:59]

Oh, I thought it was possible to build Cast, albeit stubbed, using only Chromium
code.

[gunsch, 2015/05/29 16:40:10]

It is. We don't instantiate any BrowserCdmCast instances in our public code
today.

If you want to test EME today on Chromecast, you have to either:
a) Use a Cast Android build (since the DRM plugins are already in the Android
platform)
b) Do a full Chromecast build with internal code and test on Chromecast hardware

Ideally we'd have a BrowserCdm-based ClearKey support to test Chromecast's EME
flow in the public code. crbug.com/441957 is tracking but I don't think it's
actively being worked on.

-void BrowserCdmCast::LoadSession(
-    ::media::MediaKeys::SessionType session_type,
-    const std::string& session_id,
-    scoped_ptr<::media::NewSessionCdmPromise> promise) {
-  NOTREACHED() << "LoadSession not supported";
-  legacy_session_error_cb_.Run(
-      session_id, ::media::MediaKeys::Exception::NOT_SUPPORTED_ERROR, 0,
-      std::string());
-}
-
 ::media::CdmContext* BrowserCdmCast::GetCdmContext() {
   NOTREACHED();
   return nullptr;
 }
 
 void BrowserCdmCast::OnSessionMessage(const std::string& session_id,
                                       const std::vector<uint8_t>& message,
                                       const GURL& destination_url) {
   // Note: Message type is not supported in Chromecast. Do our best guess here.
   ::media::MediaKeys::MessageType message_type =
@@ skipping 121 matching lines @@
   return nullptr;
 }
 
 // A default empty implementation for subclasses that don't need to provide
 // any key system specific initialization.
 void BrowserCdmCast::InitializeInternal() {
 }
 
 }  // namespace media
 }  // namespace chromecast